Skip to content

fix(launchtools): bind start flags to viper directly #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traviolus merged 1 commit into from
May 14, 2026
Merged

fix(launchtools): bind start flags to viper directly #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions contrib/launchtools/steps/runapp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,11 @@ func RunAppWithPostAction(postAction launchtools.PostAction) func(cfg *launchtoo
// set relevant context; this part is necessary to correctly set up the start command and their start-up flags
startCmd.SetContext(ctx.Context())

// Run PreRunE from startCmd. This step is necessary to correctly set up start-up flags,
// as it is done usually with cometbft start command.
if err := startCmd.PreRunE(startCmd, nil); err != nil {
return errors.Wrapf(err, "failed to prerun command")
// Bind start-cmd flags to the server context's viper so RunE can read them.
// On cosmos-sdk v0.50 this was done by startCmd.PreRunE, on v0.53 PreRunE was
// removed. So here we just bypass by constructing startCmd directly.
if err := ctx.ServerContext().Viper.BindPFlags(startCmd.Flags()); err != nil {
return errors.Wrapf(err, "failed to bind start flags to viper")
}

// Run RunE command - this part fires up the actual chain
Expand Down
Loading