feat(ics): bump v7 to have ibc-go v10#8
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughStandardizes Go toolchain to 1.23.6 across CI and module files; broad direct and transitive module upgrades; interchain-security consumer imports moved from v6 → v7 in voteweighted code; Curve provider URL made templated; Docker builder sets GOTOOLCHAIN=auto; minor linter, cache-initialization, and test adjustments. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 15-17: Update the vulnerable module versions in go.mod: bump
google.golang.org/grpc to v1.79.3 (or later), github.com/cometbft/cometbft to
v0.38.19 or v0.38.21, github.com/cosmos/cosmos-sdk to v0.50.14, and
github.com/ethereum/go-ethereum to v1.16.8 or v1.16.9; after changing the module
lines for these identifiers run module resolution (e.g. go get/update and go mod
tidy) to refresh go.sum and verify builds/tests pass.
In `@tests/integration/go.mod`:
- Line 14: Update the module toolchain directive currently pinned as "toolchain
go1.24.5" to "toolchain go1.23.6" so it matches CI; change the literal
"toolchain go1.24.5" entry in tests/integration/go.mod and apply the identical
edit to the same directive in tests/simapp/go.mod and tests/petri/go.mod.
In `@tests/petri/go.mod`:
- Line 5: Update the toolchain directive in tests/petri/go.mod from "toolchain
go1.24.5" to "toolchain go1.23.6" so the module's Go version matches the
repository baseline and CI workflows; edit the "toolchain" line in
tests/petri/go.mod (the toolchain directive) to use 1.23.6.
In `@tests/simapp/go.mod`:
- Line 5: The toolchain directive "toolchain go1.24.5" in tests/simapp/go.mod
must be changed to match the CI baseline; replace that directive with "toolchain
go1.23.6" so local and CI Go versions align (ensure the single-line directive
exactly reads toolchain go1.23.6).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2a44e3f4-9e8a-437d-8bf0-f42b7235c095
⛔ Files ignored due to path filters (4)
go.sumis excluded by!**/*.sumtests/integration/go.sumis excluded by!**/*.sumtests/petri/go.sumis excluded by!**/*.sumtests/simapp/go.sumis excluded by!**/*.sum
📒 Files selected for processing (13)
.github/workflows/build.yml.github/workflows/e2e.yml.github/workflows/lint.yml.github/workflows/release.yml.github/workflows/test.ymlgo.modpkg/math/voteweighted/ccv_compat.gopkg/math/voteweighted/interfaces.gopkg/math/voteweighted/math_test.gopkg/math/voteweighted/mocks/mock_cc_validator_store.gotests/integration/go.modtests/petri/go.modtests/simapp/go.mod
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
go.mod (1)
21-21:⚠️ Potential issue | 🔴 CriticalRoot module still pins vulnerable
go-ethereumandgrpcversions.
Line 21 and Line 44 keep direct dependencies on versions with known high/critical advisories. This should be upgraded before release.Suggested version bump
- github.com/ethereum/go-ethereum v1.15.5 + github.com/ethereum/go-ethereum v1.16.9 ... - google.golang.org/grpc v1.71.0 + google.golang.org/grpc v1.79.3Also applies to: 44-44
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 21, The go.mod currently pins vulnerable module versions (notably github.com/ethereum/go-ethereum and google.golang.org/grpc); update those module requirements to non-vulnerable upstream releases by replacing the existing version strings for github.com/ethereum/go-ethereum and google.golang.org/grpc with fixed versions (use the latest security-patched release), then run go get <module>@<version> for each, run go mod tidy, and run the test suite to confirm nothing breaks; ensure the updated module paths in go.mod reflect the new versions and remove any temporary replaces if used.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/go.mod`:
- Line 23: The go.mod currently pins the vulnerable module
"google.golang.org/grpc v1.71.0"; update that dependency to at least v1.79.3
(e.g., replace "google.golang.org/grpc v1.71.0" with "google.golang.org/grpc
v1.79.3" or a later patch), then run go get ./... or go get
google.golang.org/grpc@v1.79.3 and go mod tidy to refresh go.sum and ensure the
project builds with the patched grpc release.
---
Duplicate comments:
In `@go.mod`:
- Line 21: The go.mod currently pins vulnerable module versions (notably
github.com/ethereum/go-ethereum and google.golang.org/grpc); update those module
requirements to non-vulnerable upstream releases by replacing the existing
version strings for github.com/ethereum/go-ethereum and google.golang.org/grpc
with fixed versions (use the latest security-patched release), then run go get
<module>@<version> for each, run go mod tidy, and run the test suite to confirm
nothing breaks; ensure the updated module paths in go.mod reflect the new
versions and remove any temporary replaces if used.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 28798a92-3750-44b6-9546-0fba6914dcd3
⛔ Files ignored due to path filters (4)
go.sumis excluded by!**/*.sumtests/integration/go.sumis excluded by!**/*.sumtests/petri/go.sumis excluded by!**/*.sumtests/simapp/go.sumis excluded by!**/*.sum
📒 Files selected for processing (8)
contrib/images/connect.e2e.Dockerfilecontrib/images/connect.local.Dockerfilecontrib/images/connect.sidecar.dev.Dockerfilecontrib/images/connect.sidecar.prod.Dockerfilego.modtests/integration/go.modtests/petri/go.modtests/simapp/go.mod
✅ Files skipped from review due to trivial changes (2)
- contrib/images/connect.e2e.Dockerfile
- contrib/images/connect.sidecar.prod.Dockerfile
beer-1
approved these changes
Apr 24, 2026
Member
beer-1
left a comment
beer-1
left a comment
There was a problem hiding this comment.
LGTM, there is one security alert, but we are overriding this in initia side so seems good to ignore
beer-1
reviewed
Apr 24, 2026
Member
beer-1
left a comment
beer-1
left a comment
There was a problem hiding this comment.
oh but can you confirm to resolve lint issue?
traviolus
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@guide_oracle.md`:
- Line 142: Correct the typo in the user-facing instruction by replacing the
misspelled word "enther" with "enter" in the sentence that reads "with the
`oracle.json` file path, enther the following command to run connect." Ensure
the sentence still uses backticks around oracle.json and keeps punctuation
consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 38ce38a4-0881-4647-acc6-f62f41da4297
📒 Files selected for processing (3)
.github/workflows/lint.yml.golangci.ymlguide_oracle.md
💤 Files with no reviewable changes (1)
- .golangci.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/lint.yml
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/lint.yml:
- Line 42: The govulncheck workflow job is configured as non-blocking via the
continue-on-error: true setting; change continue-on-error to false (or remove
the key entirely) under the govulncheck job so vulnerability findings or scan
failures will fail the workflow and block merges, and ensure the job name
“govulncheck” and its continue-on-error key are updated accordingly.
In `@providers/apis/defi/curve/utils.go`:
- Line 17: The constant URL was changed to a templated format string (URL =
"https://prices.curve.finance/v1/usd_price/%s/%s") but DefaultAPIConfig and the
error return paths in api_handler (references: DefaultAPIConfig, URL, and the
error return statements in the Curve API handler) still expose that raw template
on failures; split into two values: keep a new constant TemplateURL (or similar)
for fmt usage and restore a concrete BaseURL (e.g., BaseURL =
"https://prices.curve.finance/v1/usd_price") used in DefaultAPIConfig, and
update the error returns in the handler to return BaseURL (or empty string)
instead of the template URL so failures do not emit "%s/%s".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 68d84208-c41b-4739-baaa-ed582bbee1c7
📒 Files selected for processing (4)
.github/workflows/build.yml.github/workflows/lint.ymlproviders/apis/defi/curve/api_handler_test.goproviders/apis/defi/curve/utils.go
✅ Files skipped from review due to trivial changes (1)
- providers/apis/defi/curve/api_handler_test.go
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/build.yml
There was a problem hiding this comment.
🧹 Nitpick comments (1)
providers/apis/defi/curve/api_handler.go (1)
64-71: Add explicit assertions for error-path returned URL.Current
TestCreateURLfailure cases only checkrequire.Error, so this newBaseURLreturn behavior isn’t locked down by tests.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@providers/apis/defi/curve/api_handler.go` around lines 64 - 71, TestCreateURL's failure branches only assert an error but don't assert the returned URL equals the error-path sentinel BaseURL; update TestCreateURL to explicitly assert the returned URL is BaseURL for each failing case (the cases that exercise the CreateURL code paths that return BaseURL on errors like the JSON parse error and network checks). Locate the test function TestCreateURL and, where it currently requires an error (require.Error / assert.Error), add a matching require.Equal or assert.Equal check that the returned URL value equals the BaseURL constant so the error-path return value is locked down.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@providers/apis/defi/curve/api_handler.go`:
- Around line 64-71: TestCreateURL's failure branches only assert an error but
don't assert the returned URL equals the error-path sentinel BaseURL; update
TestCreateURL to explicitly assert the returned URL is BaseURL for each failing
case (the cases that exercise the CreateURL code paths that return BaseURL on
errors like the JSON parse error and network checks). Locate the test function
TestCreateURL and, where it currently requires an error (require.Error /
assert.Error), add a matching require.Equal or assert.Equal check that the
returned URL value equals the BaseURL constant so the error-path return value is
locked down.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3f061a87-8b0b-451c-9cf6-a3fce0dbd1c7
📒 Files selected for processing (2)
providers/apis/defi/curve/api_handler.goproviders/apis/defi/curve/utils.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Bug Fixes
Documentation