Skip to content

chore(stdlib): deprecate cosmos::pay_fee ics-29#251

Merged
traviolus merged 1 commit into
mainfrom
chore/deprecate-pay-fee
May 27, 2026
Merged

chore(stdlib): deprecate cosmos::pay_fee ics-29#251
traviolus merged 1 commit into
mainfrom
chore/deprecate-pay-fee

Conversation

@traviolus
Copy link
Copy Markdown
Contributor

@traviolus traviolus commented May 26, 2026

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Deprecations
    • The pay_fee function in the cosmos module has been marked as deprecated and will be removed in a future release. Users are encouraged to transition to alternative solutions.

@traviolus traviolus requested a review from a team as a code owner May 26, 2026 10:15
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6a2def27-20cf-4663-96e7-5423b42e51bd

📥 Commits

Reviewing files that changed from the base of the PR and between ee3a70e and 075e05f.

📒 Files selected for processing (2)
  • precompile/modules/initia_stdlib/sources/cosmos.move
  • precompile/modules/minitia_stdlib/sources/cosmos.move

Walkthrough

The PR adds #[deprecated] annotations to the pay_fee entry function and its internal PayFeeRequest struct in both initia_stdlib and minitia_stdlib cosmos modules. Function signatures, parameters, and behavior remain unchanged.

Changes

Deprecate pay_fee IBC fee API

Layer / File(s) Summary
Mark pay_fee and PayFeeRequest as deprecated
precompile/modules/initia_stdlib/sources/cosmos.move, precompile/modules/minitia_stdlib/sources/cosmos.move
The PayFeeRequest struct and pay_fee public entry function receive #[deprecated] annotations in both cosmos modules. No function logic, request/response structures, parameters, or call patterns change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Fee functions rest in twilight's glow,
Deprecated paths bid us farewell.
New ways await, both swift and low,
Time for change breaks the API spell!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main change: deprecating the cosmos::pay_fee function per ICS-29 specification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/deprecate-pay-fee

Comment @coderabbitai help to get the list of available commands and usage tips.

@traviolus traviolus merged commit 8fb2810 into main May 27, 2026
6 checks passed
@traviolus traviolus deleted the chore/deprecate-pay-fee branch May 27, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants