Catch tool names bordered by . : - in the A2A progress leak-guard - #67
Open
Dnyaneshvn wants to merge 1 commit into
Open
Catch tool names bordered by . : - in the A2A progress leak-guard#67Dnyaneshvn wants to merge 1 commit into
Dnyaneshvn wants to merge 1 commit into
Conversation
_clean_update only treated "_" as a word boundary when checking for echoed tool
names, but the normaliser keeps ".", ":" and "-". So a tool name next to one of
those ("bash-based", "edit.py") got past the guard and sent to the untrusted
remote agent via a2a_reply.
- match echoed tool names across any non-alphanumeric boundary, not just "_"
- add tests for names bordered by "-", "." and ":"
Fixes inkbox-ai#66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66.
_clean_updateonly treated_as a word boundary when checking for echoed tool names, but the normaliser keeps.,:and-. So a tool name next to one of those ("bash-based","edit.py") got past the guard and sent to the untrusted remote agent viaa2a_reply._Tests: names bordered by
-,.and:now hit the fallback; existing underscore/space cases unchanged.Before:
"Running bash-based checks now"leaked"bash". After: suppressed. Full suite green (550).