Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,6 @@ jobs:
${{ runner.os }}-nextjs-build-${{ hashFiles('pnpm-lock.yaml') }}-
${{ runner.os }}-nextjs-build-

- name: Setup agents-docs build cache
uses: actions/cache@v4
with:
path: agents-docs/.next/cache
key: ${{ runner.os }}-nextjs-docs-build-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('agents-docs/content/**', 'agents-docs/src/**', 'packages/agents-core/src/**') }}
restore-keys: |
${{ runner.os }}-nextjs-docs-build-${{ hashFiles('pnpm-lock.yaml') }}-
${{ runner.os }}-nextjs-docs-build-

- name: Setup Playwright cache
uses: actions/cache@v4
with:
Expand All @@ -106,12 +97,11 @@ jobs:
find . -name "*.db" -o -name "*.sqlite" | grep -v node_modules | xargs -r rm -f

# Run all CI checks in parallel with Turborepo
# agents-docs build is excluded (causes OOM) — Vercel preview handles the Next.js build
- name: Run CI checks
id: ci-check
run: |
# Run all checks in parallel using Turborepo's dependency graph
# This will build once and cache, then run lint, typecheck, and test in parallel
pnpm check
pnpm exec turbo check --filter='!agents-cookbook-templates' --filter='!@inkeep/agents-docs'
env:
ENVIRONMENT: test
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY || 'sk-test-key-for-ci-testing' }}
Expand All @@ -122,6 +112,13 @@ jobs:
CI: true
HUSKY: 0

# Lint and typecheck agents-docs separately (build excluded above to avoid OOM)
- name: Lint and typecheck agents-docs
run: |
pnpm exec turbo run lint typecheck --filter=@inkeep/agents-docs
env:
CI: true
Comment on lines +115 to +120
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 Consider: Missing NODE_OPTIONS heap limit

Issue: This step doesn't inherit NODE_OPTIONS from the previous step's env block. The main CI check sets --max-old-space-size=4096, but each GitHub Actions step has an isolated environment.

Why: While lint and typecheck are significantly lighter than the Next.js build that caused the original OOM issues, adding explicit heap limits provides defensive CI hygiene and makes resource expectations clear. Memory-related CI failures (SIGKILL/exit 137) are notoriously hard to debug when they do occur.

Fix: Consider adding NODE_OPTIONS for consistency:

        env:
          CI: true
          NODE_OPTIONS: --max-old-space-size=4096

Refs:


- name: Upload Vitest Screenshots
if: failure()
uses: actions/upload-artifact@v4
Expand Down