-
Notifications
You must be signed in to change notification settings - Fork 137
ci: split agents-docs build into separate workflow #2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
094b235
ci: split agents-docs build into separate workflow to prevent OOM
nick-inkeep 4576dad
fix: correct agents-cli path in ci-docs.yml triggers
nick-inkeep ec3e8ad
fix: use pnpm exec turbo instead of bare turbo in CI
nick-inkeep f0be0fa
ci: add self-referential path trigger for ci-docs workflow
nick-inkeep 2420530
refactor: drop build from ci-docs, let Vercel own the next build
nick-inkeep 7e39baa
refactor: fold docs lint+typecheck back into main CI, delete ci-docs.yml
nick-inkeep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 Consider: Missing
NODE_OPTIONSheap limitIssue: This step doesn't inherit
NODE_OPTIONSfrom the previous step's env block. The main CI check sets--max-old-space-size=4096, but each GitHub Actions step has an isolated environment.Why: While lint and typecheck are significantly lighter than the Next.js build that caused the original OOM issues, adding explicit heap limits provides defensive CI hygiene and makes resource expectations clear. Memory-related CI failures (SIGKILL/exit 137) are notoriously hard to debug when they do occur.
Fix: Consider adding
NODE_OPTIONSfor consistency:Refs: