Bump agents-ui to 0.15.18 and disable chat history for in-app widgets …#2712
Conversation
…since they don't have appIds remove lingering references to the deprecated agentsUrl
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2183ced The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
Clean migration from the deprecated agentUrl prop to baseUrl across all widget usages. No residual agentUrl references remain in source. shouldBypassCaptcha, isChatHistoryButtonVisible: false, port correction (3003→3002), and the metadata editor updates all look correct. One minor question inline about a dropped conditional guard.
| isViewOnly: hasHeadersError, | ||
| conversationId, | ||
| agentUrl: agentId ? `${PUBLIC_INKEEP_AGENTS_API_URL}/run/api/chat` : undefined, | ||
| baseUrl: `${PUBLIC_INKEEP_AGENTS_API_URL}`, |
There was a problem hiding this comment.
The old code was conditional: agentUrl: agentId ? ... : undefined. The new code sets baseUrl unconditionally. Since ChatWidget declares agentId as optional, is it intentional to always provide baseUrl even when there's no agentId? If the widget can function without an agent (e.g. as a generic chat), this is fine — just confirming the guard removal was deliberate.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
This is a clean, well-scoped PR that migrates from the deprecated agentUrl prop to the new baseUrl pattern in @inkeep/agents-ui. The changes correctly:
- Update all internal widget usages to use
baseUrlinstead ofagentUrl - Disable chat history for in-app widgets (copilot, playground, chat-ui-guide) since they use headers-based auth without
appId - Add
shouldBypassCaptcha: truefor internal development tools - Update UI copy and navigation to guide users toward the Apps flow instead of API keys
- Add generated documentation for new Chat History CSS classes
💭 Consider (3) 💭
Inline Comments:
- 💭 Consider:
copilot-chat.tsx:242Unnecessary template literal wrapping single variable - 💭 Consider:
chat-widget.tsx:232Unnecessary template literal wrapping single variable - 💭 Consider:
metadata-editor.tsx:71Unnecessary template literal wrapping single variable
💭 1) system Documentation for Chat History feature
Issue: The generated CSS classes for Chat History Components are documented, but the feature itself (what chat history is, how to enable/disable it via isChatHistoryButtonVisible, and the appId requirement) is not documented.
Why: Users will see CSS classes like ikp-ai-chat-history__item but won't find docs explaining the feature or the new prop.
Fix: Consider adding a brief section to the chat components docs explaining chat history and the isChatHistoryButtonVisible prop. This could be a follow-up PR.
Refs: style-classnames.mdx:190-206
💭 2) system Version consistency via pnpm catalog
Issue: Prior to this PR, @inkeep/agents-ui versions were inconsistent across packages (0.15.13, 0.15.14). This PR aligns them all to 0.15.18.
Why: Using pnpm workspace catalog for external dependencies like @inkeep/agents-ui would prevent future version drift.
Fix: Consider adding @inkeep/agents-ui to the workspace catalog for consistent versioning. This is a future improvement, not blocking.
✅ Looks Good To Merge
Summary: Clean PR that correctly migrates widget props from the deprecated agentUrl to the new baseUrl + appId pattern. The changes are well-scoped, consistent across all affected files, and the changeset is appropriate. The template literal suggestions are purely stylistic nitpicks. Ship it! 🚀
Discarded (5)
| Location | Issue | Reason Discarded |
|---|---|---|
use-in-your-app-section.tsx:44-45 |
Placeholder values instead of actual runtime values | Pre-existing behavior - function already used placeholder text before this PR |
chat-ui-guide.tsx:29-31 |
Preview disables chat history but generated code doesn't | Intentional design - in-app widgets don't have appIds, generated code assumes users will |
use-in-your-app-section.tsx:32 |
No tests for code snippet generation | Pre-existing - no tests existed before this PR |
component-name-utils.ts |
No tests for utility functions | Pre-existing - not introduced by this PR |
@inkeep/agents-ui versions |
Prior version inconsistency | Already fixed by this PR - all aligned to 0.15.18 |
Reviewers (8)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-standards |
0 | 0 | 0 | 0 | 0 | 0 | 0 |
pr-review-product |
3 | 0 | 0 | 0 | 0 | 0 | 2 |
pr-review-consistency |
4 | 0 | 0 | 0 | 0 | 0 | 0 |
pr-review-breaking-changes |
3 | 0 | 0 | 0 | 0 | 0 | 0 |
pr-review-docs |
3 | 0 | 1 | 0 | 0 | 0 | 0 |
pr-review-tests |
2 | 0 | 0 | 0 | 0 | 0 | 2 |
pr-review-frontend |
3 | 0 | 0 | 0 | 3 | 0 | 0 |
pr-review-devops |
4 | 0 | 1 | 0 | 0 | 0 | 1 |
| Total | 22 | 0 | 2 | 0 | 3 | 0 | 5 |
Note: All 8 reviewers returned clean findings. Most findings were either positive confirmations (INFO) or pre-existing issues not attributable to this PR.
| dark: '/assets/inkeep-icons/icon-sky.svg', | ||
| }, | ||
| agentUrl: `${PUBLIC_INKEEP_AGENTS_API_URL}/run/api/chat`, | ||
| baseUrl: `${PUBLIC_INKEEP_AGENTS_API_URL}`, |
There was a problem hiding this comment.
💭 Consider: Unnecessary template literal
Issue: Template literal wraps a single variable with no interpolation needed.
Why: Previously, agentUrl concatenated the path (/run/api/chat), so the template literal was needed. Now with just baseUrl, it's redundant.
Fix: (1-click apply)
| baseUrl: `${PUBLIC_INKEEP_AGENTS_API_URL}`, | |
| baseUrl: PUBLIC_INKEEP_AGENTS_API_URL, |
Refs:
- Same pattern applies to chat-widget.tsx:232 and metadata-editor.tsx:71
| isViewOnly: hasHeadersError, | ||
| conversationId, | ||
| agentUrl: agentId ? `${PUBLIC_INKEEP_AGENTS_API_URL}/run/api/chat` : undefined, | ||
| baseUrl: `${PUBLIC_INKEEP_AGENTS_API_URL}`, |
There was a problem hiding this comment.
💭 Consider: Unnecessary template literal
Issue: Template literal wraps a single variable with no interpolation needed.
Fix: (1-click apply)
| baseUrl: `${PUBLIC_INKEEP_AGENTS_API_URL}`, | |
| baseUrl: PUBLIC_INKEEP_AGENTS_API_URL, |
| metadata; | ||
| const { PUBLIC_INKEEP_AGENTS_API_URL } = useRuntimeConfig(); | ||
| const agentUrl = `${PUBLIC_INKEEP_AGENTS_API_URL}/run/api/chat`; | ||
| const baseUrl = `${PUBLIC_INKEEP_AGENTS_API_URL}`; |
There was a problem hiding this comment.
💭 Consider: Unnecessary template literal
Issue: Template literal wraps a single variable with no interpolation needed.
Fix: (1-click apply)
| const baseUrl = `${PUBLIC_INKEEP_AGENTS_API_URL}`; | |
| const baseUrl = PUBLIC_INKEEP_AGENTS_API_URL; |
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
Delta Review Summary
This is a re-review scoped to changes since the last automated review (ea5b81e34cb2).
Delta commits:
906e950b7— Removes unnecessary string interpolation8b68134d9— Merge commit from main53942459d— Unrelated PR #2708 merged into main (OAuth credentials CRUD)
Assessment: The only change relevant to this PR's scope is the removal of unnecessary template literals in three files:
copilot-chat.tsx:242— Now usesbaseUrl: PUBLIC_INKEEP_AGENTS_API_URL,✅chat-widget.tsx:232— Now usesbaseUrl: PUBLIC_INKEEP_AGENTS_API_URL,✅metadata-editor.tsx:71— Now usesconst baseUrl = PUBLIC_INKEEP_AGENTS_API_URL;✅
This directly addresses the 3 "Consider" inline comments from the previous review. No new issues introduced.
🕐 Pending Recommendations (2)
- 💭
systemDocumentation for Chat History feature (optional follow-up) - 💭
systemVersion consistency via pnpm catalog (optional improvement)
✅ APPROVE
Summary: Clean delta that addresses prior review feedback. The unnecessary template literals have been removed as suggested. The original PR scope (migrating from agentUrl to baseUrl, disabling chat history for in-app widgets, updating UI copy) was already approved in the previous review. Ship it! 🚀
Reviewers (0)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
| Total | 0 | 0 | 0 | 0 | 0 | 2 | 0 |
Note: Delta review — no sub-reviewers dispatched since the delta only contains fixes for prior review feedback.
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
Delta Review Summary
This is a re-review scoped to changes since the last automated review (906e950b7dbb).
Delta commits:
2183ced88— Merge branch 'main' into prd-6311
Assessment: The delta contains only a merge from main (PR #2701 — DAL scope helper migration). This is entirely unrelated to this PR's scope. No changes to the 14 files in this PR.
The prior reviews comprehensively covered this PR:
- ✅ Migration from
agentUrltobaseUrl— verified correct - ✅ Chat history disabled for in-app widgets — verified correct
- ✅ Template literal cleanup — addressed in
906e950b7 - ✅ UI copy updates (API Keys → Apps) — verified correct
- ✅ Changeset appropriate — verified correct
🕐 Pending Recommendations (2)
- 💭
systemDocumentation for Chat History feature (optional follow-up) - 💭
systemVersion consistency via pnpm catalog (optional improvement)
✅ APPROVE
Summary: No new issues in the delta — it's just a merge from main with unrelated changes. The PR remains clean and ready to ship. The original migration work was thoroughly reviewed in prior passes. 🚀
Reviewers (0)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
| Total | 0 | 0 | 0 | 0 | 0 | 2 | 0 |
Note: Delta review — no sub-reviewers dispatched since the delta contains only merge commits from main with no changes to files in this PR's scope.
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Inkeep Agent Framework Docs' |
Ito Test Report ✅8 test cases ran. 8 passed. ✅ The passing coverage confirms the base URL migration UI contract in metadata, playground history-button suppression, malformed-header safety behavior, demo-width behavior, and XSS/header hardening checks. 🔍 Non-passing outcomes were reviewed against repository code and runtime-change artifacts, and only code-supported defects are eligible for failed classification. ✅ Passed (8)
📋 View Recording |
1 participant
…since they don't have appIds remove lingering references to the deprecated agentsUrl