fix(open-knowledge): reset worker content baseline for FileTree empty-space flakes (#1911)#185
Merged
Merged
Conversation
…-space flakes (#1911) (#1933) * docs(open-knowledge): playbook lesson — verify flake fixes under full-suite contention The restored e2e-stability detector's first run caught file-tree-deselect:61 still flaking under workers=4 full-suite contention, after it had verified 30/30 green in an isolated --repeat-each run. Adds Round-2 retro point 5: an isolated single-spec run can false-green; the done-gate must run the spec inside the full suite (detector invocation), not alone. * fix(open-knowledge): reset worker content baseline before FileTree empty-space tests The workerServer fixture is shared across every e2e test on a Playwright worker, and api.testReset() only truncates the single test-doc doc, so docs created by prior specs persist and accumulate on that worker. Under the full concurrent suite the sidebar fills past the viewport, so the empty area the deselect test clicks (box.height - 8) is actually a real row (selecting it steals roving focus), and a leftover root note from an earlier drag-to-root promotion collides with the next (two same-named rows). Both are contention- only flakes the e2e-stability detector caught (#1911) that an isolated --repeat-each run missed. Adds a shared resetContentToFixtureBaseline helper (the shared form of the per-spec clearVisibleContentEntries already in file-tree-create and editor- tabs) plus a beforeEach in file-tree-deselect-to-root and file-tree-drag-to- root that restores the boot-seeded baseline, preserving REQUIRED_FIXTURE_ENTRY_NAMES. GitOrigin-RevId: 0955c9f2d6d8e90013c4d0ea71583d4cb259e9c3
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/in/2806322?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/27714937182). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.