Remove the broken "Upload file" button from the file sidebar. This…#187
Merged
Conversation
* fix(open-knowledge): remove broken upload file button from sidebar Remove the upload-via-file-picker entry points: the sidebar toolbar button, the folder and empty-area right-click menu items, and the empty-state button. Also remove the now-dead picker plumbing (chooseSidebarUploadFiles, uploadFilesToTargetFromPicker, the FileTreeHandle.uploadFiles method, and the onUploadFiles prop). Drag-and-drop file upload onto the file tree is unchanged; it routes through the separate uploadExternalFilesToTarget pipeline. Update the FileSidebar DOM tests to drop the removed affordances. * fix(open-knowledge): regenerate i18n catalogs after dropping upload-file usages Removing the "Upload file" affordances from FileSidebar and FileTree dropped two source-path references from the "Upload file" message in the .po catalogs (the message itself stays via PropPanel's aria-label). Run bun run i18n to resync; the compiled .json catalogs are unchanged. Fixes the i18n-drift failure in the open-knowledge / lint CI job. GitOrigin-RevId: 2580a40825945c8d4e712873095e5a34f82f166f
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/in/2806322?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/27719884757). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the broken "Upload file" button from the file sidebar. This drops the upload-via-file-picker entry points: the sidebar toolbar button, the folder and empty-area right-click menu items, and the empty-state button. Drag-and-drop file upload onto the file tree is unchanged.