fix(prop-panel): scroll-aware popover height + explicit Done button#188
Merged
Conversation
…#1937) Two of the four strands in the PRD-7058 cluster — the two with clear scope. #3 (Align broken) did not reproduce once #2 was fixed; the reporter had no path to reach the Align field through the un- scrollable popover. #4 (drag-resize for image/PDF) is a separate feature and lands in its own PR. 1. **#2 popup scroll** — `max-h-[calc(100vh-2rem)]` ignored the popover's top position, so a popover positioned 200px down the viewport was capped at the FULL viewport height — overflowed off- screen and never engaged its internal scroller. Switch to `max-h-[var(--radix-popper-available-height)]`, which Radix's Popper plugin pre-computes as "height available between the anchor and the chosen-side viewport edge." The popover now caps at the actual available space, so its `overflow-y-auto` engages and every advanced prop becomes reachable. 2. **#1 silent dismiss** — add an explicit "Done" button at the bottom of the popover, separated from the form by a top border. PropPanel still auto-saves on every keystroke / select change (the button doesn't gate the write); the affordance gives users the psychological closure UX research flagged was missing ("I just write, and it just, like, disappears"). Click closes the popover; the existing `onCloseAutoFocus` editor-refocus path handles focus restore. GitOrigin-RevId: 1e721d365b69fee7904d4d88c8c8e9303add8a99
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/in/2806322?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/27721932693). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.