Skip to content

fix: deduplicate regex capture group in HTML link attribute parser #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fix2015 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: deduplicate regex capture group in HTML link attribute parser #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/server/src/asset-references.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const MARKDOWN_LINK_OR_IMAGE_RE =
/!?\[[^\]\n]*(?:\][^[\]\n]*)?\]\((?:<([^>\n]+)>|([^)\s]+))(?:\s+['"][^'"]*['"])?\)/g;
const WIKI_LINK_OR_EMBED_RE = /!?\[\[([^[\]|#]+?)(?:#[^\]|]+?)?(?:\|[^\]]+?)?\]\]/g;
const HTML_LINK_ATTR_RE =
/<[\w:-]+\b[^>]*?\s+(?:href|src)\s*=\s*(?:"([^"\n]*)"|'([^'\n]*)'|“([^”\n]*)”|([^\s"'=<>`]+))/gi;
/<[\w:-]+\b[^>]*?\s+(?:href|src)\s*=\s*(?:”([^”\n]*)”|'([^'\n]*)'|\u201c([^\u201d\n]*)\u201d|([^\s”'=<>`]+))/gi;

export function isRemoteOrOpaqueHref(href: string): boolean {
return (
Expand Down
Loading