Share .ok/skills in local-only mode via a Skills carve-out toggle (#2711)#673
Merged
Conversation
…711) * Share .ok/skills in local-only mode via a Skills carve-out toggle In local-only sharing mode the whole .ok/ tree is added to .git/info/exclude, so project skills under .ok/skills (shareable content, not machine-local config) silently cannot be committed or shared. Git refuses to re-include a path whose parent dir is excluded, so a bare !.ok/skills/ after .ok/ does not work. The carve-out replaces the blanket .ok/ line with **/.ok/* plus !**/.ok/skills/ - skills become committable at any depth while local/, config.yml, worktrees/ and PII files stay hidden. Core: setSkillsShared / readSkillsShared in git-exclude.ts; removeOkPaths strips the carve lines on the shared transition; readSharingMode recognizes the carve as local-only. Desktop: a set-skills-shared IPC dispatch and a skillsShared status field. UI: a one-click "Share skills" prompt in the Skills sidebar (local-only only), plus a SharingSection "skills are shared" indicator with an Undo so the carve state is visible and reversible. CLI: ok config-sharing status reports skillsShared and a carve-state note. * Address re-review: fix Undo result-inspection + doc/CLI polish - SharingSection.onUndoSkillsShare now inspects the setSkillsShared(false) result like onSelect does: a `no-exclude` outcome (git config unavailable / exclude file unwritable) surfaces a warning instead of a false success. - Map `no-exclude` reason codes (no-git / inaccessible / other) to plain English in both the sidebar share toast and the Settings Undo toast, instead of leaking internal terms like `malformed-pointer`. - CLI `ok config-sharing status`: in the carve state, clarify that the "Toggle with" hint shares the whole project and skills-only undo is a desktop action, so it isn't misread as an undo-the-carve command. - Refresh the stale "two-method" sharing-dispatch comments in preload/index.ts and ipc-channels.ts to name the third arm (set-skills-shared / setSkillsShared). GitOrigin-RevId: 95ce9e4cbabeabd20069832a0b509357c59709d7
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.