feat(open-knowledge): math WYSIWYG autoconvert + inline popover polish (#2715)#677
Merged
Conversation
…h (#2715) * feat(open-knowledge): autoconvert $$…$$ / $…$ in WYSIWYG and polish the inline math popover Adds a TipTap InputRule that collapses $$…$$ and (currency-safe) $…$ to a mathInline atom on the closing delimiter, using the same dispatchAsOwnUndoStep contract inline-link-input-rule uses so Ctrl+Z restores the raw literal without also undoing the preceding typing. Inline-math edit popover now closes on Enter (via PropPanel's onDismiss wiring) and gains a Done button matching the JsxComponentView pattern. On close the caret lands right after the atom so typing continues inline instead of the NodeSelection swallowing the next keystroke. * test(open-knowledge): cover math input rule + refresh i18n catalogs Adds 10 vitest cases mirroring inline-link-input-rule.test.ts: conversion for $$…$$ and $…$, currency-safety ($5.00, foo$x$, $ x $ all stay literal), code-block exclusion, and the one-undo-restores-the-literal contract against a real y-undo binding. Also picks up the two new po entries lingui extract generates for the Inline Math Properties popover header and the Done button. GitOrigin-RevId: e5f7aa04f32b3253d5cd1d6ab0f4288b9168e253
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.