Deflake gc packing test and harden local perf gates (PRD-7494) (#2773)#722
Merged
Conversation
The maintenance-coordinator packing test asserted git gc --auto's packing outcome, but --auto estimates loose-object count by sampling the objects/17 fanout dir, which lands under threshold ~6.8% of runs with 1500 random seeds. The test now writes three precomputed blobs that hash into objects/17, pinning the sample over threshold so gc packs every run. The A1/A2 race tests seed the same pins so the gc-vs-commit interleaving is actually exercised every run. Verified 25/25 consecutive green under load. The comment-discipline perf gate's wall-clock medians inflate when the machine is saturated by sibling test tiers. The verdict now accepts either the wall-clock median or the process CPU-time median within the same unchanged budgets; CPU time excludes scheduler wait but still grows with any real slowdown of the CPU-bound ts-morph work. The per-test timeout widens to a hang guard that lets the measurement finish under load. The M2 project-markdown sweep parsed the whole repo in one test under one flat timeout, so total work scaled with the repo while the cap did not. The sweep is now sliced into 8 round-robin batches, bounding the work each timeout guards without changing the zero-whole-doc-fallback gate. GitOrigin-RevId: 7134ab7b4cecfcb3762b00bacac4ad02b26dba42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.