test(open-knowledge): add test:e2e membership guard (PRD-7493) (#2774)#723
Merged
Conversation
CI's Playwright tier runs the fixed test:e2e file list, so any stress e2e file left off the list silently never runs. 32 of 83 files had drifted into that invisible set, plus one listed file that no longer exists on disk. - Add tests/meta/e2e-ci-membership.test.ts: every tests/stress/*.e2e.ts must be in exactly one of the test:e2e enumeration or the exclusion ledger; fails on CI-invisible files, files in both lists, stale ledger entries, stale enumeration entries, and nested e2e files outside the guard's top-level scope. Predicate is pure with planted fixtures. - Add tests/stress/e2e-ci-ledger.ts: reviewed per-file reason and evidence for the 13 files kept out of CI (12 fail locally with deterministic signatures across 2 runs; graph-panel-surfaces also blows the CI time budget). - Promote 20 triaged files into test:e2e: each was green on 2 consecutive local runs and the whole set runs in about 1 minute at workers=4 (roughly 181 test-seconds total). - Drop the stale tests/stress/file-tree-compact-folders.e2e.ts token (never existed on main; left over from #1903). GitOrigin-RevId: 12b01513cdf10ff834cb582aea593599065d41d4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.