feat!: reuse TCP connection by default#134
Open
figueredo wants to merge 1 commit into
Open
Conversation
figueredo
requested review from
FranciscoGileno,
julianalucena,
marcelscr and
ottony
as code owners
There was a problem hiding this comment.
Pull request overview
This PR changes the SDK’s HTTP behavior so TCP connection reuse is enabled by default, improving request performance without requiring extra client configuration.
Changes:
- Updates
RequestManagerto defaultkeepAlivetotrue. - Adds tests covering the new default and explicit opt-out behavior.
- Updates README option documentation to reflect the new default.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/request.ts |
Changes the internal HTTPS agent default to enable keep-alive. |
test/request.test.ts |
Adds coverage for default keep-alive behavior and disabling it. |
README.md |
Updates documented keepAlive default from false to true. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marcelscr
approved these changes
May 15, 2026
figueredo
force-pushed
the
feat/keep-alive-true
branch
from
a93cc19 to
c48ebfa
Compare
figueredo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change TCP connection reuse to be default behavior so that clients have better performance with less configuration.