Move filter building blocks to shared UI components and reuse across drawers#7120
Open
AronH99 wants to merge 1 commit into
Open
Move filter building blocks to shared UI components and reuse across drawers#7120AronH99 wants to merge 1 commit into
AronH99 wants to merge 1 commit into
Conversation
…drawers Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
LukasStordeur
left a comment
Collaborator
There was a problem hiding this comment.
We have a lot of "onAddxxxx", "removexxxChip" "clearxxx" it might be worth having a generic hook that takes the filterKey for those. Maybe make better use of the wrapper we currently already use ConnectedFilterWidget and let it have a Context with a config we pass to it?
A bit like the form generator, but in a less convoluted way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Own words:
The AI description sums up a lot already.
In general there were a lot of patterns for the filter drawers who could be deduplicated/extracted, which I did and then I adjusted it everywhere necessary in the same shape/style.
So everything should honestly be really consistent with the exact same code/style implementations.
Also removed unused stuff or renamed files for naming consistency as well.
All in all solid refactor I reckon, I adjusted the ticket to mostly match what happened in this PR.
Let me know if you have any concerns/feedback.
Ps: Got no screenshot(s) because everything stayed exactly the same, functionally and visually.
closes #7027