fix(admin): resync package-lock.json with package.json - #97
Merged
Conversation
admin:test failed on every CI run with "Missing: sortablejs@1.14.0 from lock file" — `npm ci` refuses to install when the lock file and package.json disagree, and it did here: vuedraggable, @iconify/vue and @vuepic/vue-datepicker (plus their transitive deps — sortablejs, @floating-ui/*, @vueuse/*, date-fns) are all declared in package.json but were entirely absent from package-lock.json. Someone added them without running an install that would have regenerated the lock. Regenerated with `npm install --package-lock-only` inside a node:22 container (matching the CI image exactly), then verified `npm ci` and `npm run build-only` both succeed clean against the new lock file. admin/yarn.lock changed too when I ran this locally, for reasons I don't have an explanation for — reverted that separately since nothing in this project's CI or scripts reads it, and an unexplained lockfile diff isn't something to fold into an unrelated fix. Co-Authored-By: Hakob Vardanyan <info@innovayse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
admin:testfailed on every CI run withMissing: sortablejs@1.14.0 from lock file.npm cirefuses to install when the lock file andpackage.jsondisagree, and they did:vuedraggable,@iconify/vueand@vuepic/vue-datepicker(plus transitive deps —sortablejs,@floating-ui/*,@vueuse/*,date-fns) are declared inpackage.jsonbut were entirely absent frompackage-lock.json.Regenerated with
npm install --package-lock-onlyinside anode:22container (matching the CI image). Verifiednpm ciandnpm run build-onlyboth succeed clean against the new lock file.Found while fixing the
builder-tag runner gap that was leaving every hostpanel pipeline stuck pending forever — once jobs could actually run, this was one of two pre-existing failures the pipeline had never been able to surface before now (the other is a broken admin-seed login path in the integration test suite, tracked separately).