Send client's IP to GA - #36
Open
coccoinomane wants to merge 3 commits into
Open
coccoinomane wants to merge 3 commits into
coccoinomane wants to merge 3 commits into
Conversation
The IP is added to the payload data in getTrackingPayloadData(). The function 'getClientIp' is introduced to obtain the client's IP. Note that GA will anonymize the IP, so make sure that your IP filters in GA do not rely on the last three digits of the IP. For details, see issue #33
Owner
|
Thanks @coccoinomane. Could you please fix the failed build
|
Author
|
Hi @ins0! I included isset() checks in the getClientIp() function; this fixes the PHP notice. |
Owner
|
HHmm currently not a home, looks like some wired change will have a look later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #33.
The IP is added to the payload data in getTrackingPayloadData().
The function 'getClientIp' is introduced to obtain the client's IP.
Note that GA will anonymize the IP, so make sure that your IP filters in GA do not rely on the last three digits of the IP.