Skip to content

363 default format label#364

Merged
shajoezhu merged 2 commits into
mainfrom
363_default_format_label
Nov 27, 2025
Merged

363 default format label#364
shajoezhu merged 2 commits into
mainfrom
363_default_format_label

Conversation

@gmbecker

Copy link
Copy Markdown
Collaborator

Closes #363, will underly update to rtables and small change to tern

@github-actions

github-actions Bot commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files    8 suites   15s ⏱️
 56 tests  56 ✅ 0 💤 0 ❌
424 runs  424 ✅ 0 💤 0 ❌

Results for commit f47a49f.

♻️ This comment has been updated with latest results.

@github-actions

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       265       5  98.11%   117, 223, 262, 537, 545
R/generics.R           125      12  90.40%   148, 286-290, 492, 504, 535, 565, 673, 686, 707-714
R/labels.R              55       7  87.27%   51, 57, 66, 107, 133, 142, 146
R/matrix_form.R        695      37  94.68%   134, 174, 405, 525-526, 618, 628-631, 649, 680, 770-771, 785-790, 820-823, 883-884, 973-974, 1001, 1029, 1081, 1243, 1279, 1336, 1384, 1387, 1391
R/mpf_exporters.R      287      28  90.24%   2, 102-112, 157, 193, 238, 241, 246, 426-432, 436, 439, 443, 491, 570
R/page_size.R           42       1  97.62%   219
R/pagination.R         770      56  92.73%   327-330, 435-450, 540, 595, 600, 641, 679-690, 766, 878-879, 901-910, 1051, 1054, 1275, 1312-1316, 1333-1341, 1422, 1562-1563, 1579-1580, 1594-1595
R/tostring.R           783      66  91.57%   88, 296, 351, 421, 454, 462, 498, 555-558, 594, 660-663, 669-673, 676-679, 686-691, 774-775, 915-916, 981-988, 1038-1042, 1111, 1164, 1183-1187, 1198, 1216, 1233, 1248, 1346, 1389, 1434, 1520, 1559, 1613, 1620
R/utils.R                3       0  100.00%
R/zzz.R                 17       6  64.71%   28-33
TOTAL                 3042     218  92.83%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  -------
R/format_value.R       +3       0  +0.02%
R/pagination.R         -1       0  -0.01%
TOTAL                  +2       0  +0.00%

Results for commit: f47a49f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@shajoezhu

Copy link
Copy Markdown
Contributor

hi @gmbecker , downstream breaking changes, https://github.com/insightsengineering/formatters/actions/runs/19689302914/job/56401607957 can you please take a look. thank you

@edelarua edelarua mentioned this pull request Nov 27, 2025
34 tasks
@shajoezhu

shajoezhu commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

no breaking changes at insightsengineering/scda.test#200

@shajoezhu
shajoezhu enabled auto-merge (squash) November 27, 2025 22:40

@shajoezhu shajoezhu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @gmbecker

@shajoezhu
shajoezhu merged commit be6f4bb into main Nov 27, 2025
33 of 34 checks passed
@shajoezhu
shajoezhu deleted the 363_default_format_label branch November 27, 2025 22:40
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "default" format label

2 participants