export subset_cols and has_force_pag#1026
Merged
Merged
Conversation
gmbecker
requested review from
Melkiades,
ayogasekaram and
edelarua
as code owners
June 2, 2025 21:59
Contributor
Unit Tests Summary 1 files 28 suites 1m 49s ⏱️ Results for commit 9d1a41b. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit 18d8e33 ♻️ This comment has been updated with latest results. |
Contributor
Code Coverage SummaryDiff against mainResults for commit: 9d1a41b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Melkiades
reviewed
Jun 3, 2025
Co-authored-by: Davide Garolini <davide.garolini@roche.com> Signed-off-by: Gabe Becker <gabembecker@gmail.com>
Melkiades
approved these changes
Jun 4, 2025
Melkiades
left a comment
Contributor
There was a problem hiding this comment.
Lgtm!!! Thanks Gabe. Also very nicely self-contained. It was straightforward to review ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean lint for me locally. NEWS updated. Explicit tests as requested.
Closes #1025