Skip to content

vignette on translating shells to layouts#1044

Merged
shajoezhu merged 8 commits into
mainfrom
1043_shells_vignette
Oct 27, 2025
Merged

vignette on translating shells to layouts#1044
shajoezhu merged 8 commits into
mainfrom
1043_shells_vignette

Conversation

@gmbecker

Copy link
Copy Markdown
Collaborator

No description provided.

@gmbecker

Copy link
Copy Markdown
Collaborator Author

Closes #1043

@github-actions

github-actions Bot commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files     28 suites   1m 51s ⏱️
  234 tests   234 ✅ 0 💤 0 ❌
1 748 runs  1 748 ✅ 0 💤 0 ❌

Results for commit da8c6d0.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Tabulation framework 💚 $20.79$ $-1.07$ $0$ $0$ $0$ $0$

Results for commit b522e31

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R               812      63  92.24%   20, 94, 97, 428, 519-520, 523, 681, 785, 877-878, 980, 983, 985-986, 1004-1007, 1027, 1142-1145, 1243-1248, 1404, 1504-1507, 1613-1616, 1652-1655, 1661-1666, 1717, 1724, 1818, 1926, 1939, 1942-1945, 1948-1951, 1978, 2010-2011
R/as_html.R                    172      25  85.47%   5-10, 77, 149-154, 159-164, 179-183, 270
R/colby_constructors.R         603      26  95.69%   81, 134, 197-200, 267-270, 411, 427, 1203, 1292, 1453, 1492, 1503, 1511, 1514, 1539, 1560, 1706, 1929-1932
R/compare_rtables.R             83      17  79.52%   93-96, 99-102, 115-118, 137, 156-157, 188, 193
R/custom_split_funs.R          265      40  84.91%   127, 132, 138-143, 156, 173-177, 353-358, 375-380, 456, 502, 518-521, 537, 599, 609-610, 612, 624, 668, 693
R/default_split_funs.R         287      22  92.33%   272, 335-338, 349-350, 352, 354, 551-555, 619-622, 685-688
R/format_rcell.R                13       0  100.00%
R/indent.R                      13       2  84.62%   40-41
R/index_footnotes.R             66       0  100.00%
R/make_split_fun.R             138      31  77.54%   22-26, 36-39, 52-55, 58-61, 115, 119, 267, 270-273, 278-281, 295, 366, 375, 377, 379, 430
R/make_subset_expr.R           137      15  89.05%   35, 47-61, 135-142, 178, 267, 271, 280
R/summary.R                    144      38  73.61%   35, 80, 178-220, 269, 315-331, 366, 397
R/tree_accessors.R            1256     147  88.30%   110, 139-140, 264, 284, 310, 333, 363, 381, 400-404, 426, 448-451, 566, 593-594, 880-886, 1030, 1049, 1075, 1127, 1184-1185, 1222, 1257, 1295-1300, 1359, 1433-1437, 1455-1464, 1542, 1662-1665, 1690, 1712-1713, 1723, 1774, 1795-1800, 1821-1826, 1837, 1911, 1952, 2051, 2158, 2171, 2185, 2201, 2210, 2220-2224, 2274-2279, 2482, 2492-2495, 2505, 2530-2533, 2540, 2542-2545, 2667, 2701-2702, 2759, 3064, 3425, 3541, 3575-3600, 3691-3699, 3860, 3934-3940, 4247, 4371, 4456-4461, 4467, 4491-4496, 4544, 4569-4593, 4622
R/tt_afun_utils.R              417      33  92.09%   57, 178, 185, 194-208, 276, 284-285, 503, 511-514, 596-600, 620, 634-636
R/tt_as_df.R                   400      23  94.25%   100-103, 111, 149, 223-226, 368, 387, 457, 476-479, 488, 598, 604, 636, 654, 706
R/tt_compare_tables.R           72       4  94.44%   51, 174, 249, 253
R/tt_compatibility.R           570      70  87.72%   19, 142-143, 186, 191, 319-320, 324-327, 333, 337, 521, 575-578, 615-617, 655, 688, 708, 728-731, 741-744, 789, 806-810, 816-819, 893, 920-923, 932, 994, 1002, 1013-1016, 1127, 1134, 1162-1176, 1207-1208
R/tt_dotabulation.R           1174      95  91.91%   60, 255, 260, 262, 311, 336, 340-343, 376-379, 402, 435-438, 466-469, 567, 709-713, 763, 767, 795-798, 808, 828-832, 839-842, 1106, 1110, 1141, 1244-1247, 1459-1467, 1731-1740, 1822-1825, 1836, 1841, 1846-1847, 1849, 1860, 1865, 1888, 1974-1993
R/tt_export.R                   13       1  92.31%   45
R/tt_from_df.R                  15       0  100.00%
R/tt_paginate.R                532      39  92.67%   74, 122-131, 336-337, 489, 624-627, 648-652, 797-800, 851-858, 935, 938, 956, 963, 966
R/tt_pos_and_access.R          654      33  94.95%   76, 78-80, 105, 166, 262, 329, 438, 512, 516, 724, 726, 734, 740, 754, 764-767, 989, 1006-1009, 1036, 1095-1096, 1109, 1350-1351, 1377-1380, 1654, 1729
R/tt_showmethods.R             162      21  87.04%   56, 91-113, 223, 249, 258, 263, 266-270, 359-360
R/tt_sort.R                    115       6  94.78%   50, 289-292, 300
R/tt_toString.R                436      24  94.50%   126, 350, 372, 385, 395, 401, 404, 410-420, 513, 614, 821-846
R/utils.R                       34       7  79.41%   56, 169-174
R/validate_table_struct.R       84      10  88.10%   80-84, 93-94, 140, 149-150
R/Viewer.R                      61       9  85.25%   46, 50, 60-64, 84, 118
TOTAL                         8728     801  90.82%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: da8c6d0

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@shajoezhu

Copy link
Copy Markdown
Collaborator

This is fantasitc! thanks so much @gmbecker , can you check the failing tests please. Thanks!

@gmbecker

Copy link
Copy Markdown
Collaborator Author

@shajoezhu all checks now passing except spell check which i intentionally skipped because it continues to give me trouble with accented letters such as those in Daniels name.

@shajoezhu shajoezhu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @gmbecker

@shajoezhu
shajoezhu merged commit a85e7db into main Oct 27, 2025
30 checks passed
@shajoezhu
shajoezhu deleted the 1043_shells_vignette branch October 27, 2025 07:33
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants