Export splv_extra and value_expr accessors#1098
Merged
Melkiades merged 5 commits intoJul 1, 2026
Merged
Conversation
Contributor
|
✅ All contributors have signed the CLA |
Contributor
Author
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Melkiades
requested changes
Jun 30, 2026
Melkiades
left a comment
Contributor
There was a problem hiding this comment.
examples fail check (SplitValue() not exported) and docs need re-document (int_methods.Rd still has the value_expr/splv_extra aliases, now duplicated). minor typo in NEWS
Contributor
Author
Contributor
Author
Good catch, updated ! |
Melkiades
requested changes
Jul 1, 2026
Melkiades
left a comment
Contributor
There was a problem hiding this comment.
Could you fix the CICD? Thanks
Contributor
Author
Melkiades
reviewed
Jul 1, 2026
Melkiades
enabled auto-merge (squash)
July 1, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Exports two previously internal accessors needed by downstream package (
junco).splv_extra / splv_extra<- : get/set child-specific extra arguments on a SplitValue object
value_expr : retrieve the subsetting expression from a SplitValue / ValueWrapper object
see -> johnsonandjohnson/junco#318