Skip to content

Jnj templates scripts 4 change column alignment #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
munoztd0 wants to merge 5 commits into from
Closed

Jnj templates scripts 4 change column alignment #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0de2d45
update: change the column alignment, and see how much it can change
munoztd0 Mar 5, 2026
022e08e
[skip style] [skip vbump] Restyle files
github-actions[bot] Mar 5, 2026
dbfc4ff
fix: out of bounds
munoztd0 Mar 6, 2026
e733589
fix: merge conflicts
munoztd0 Mar 6, 2026
e57bf17
[skip style] [skip vbump] Restyle files
github-actions[bot] Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/testthat/source_code/lsfae01.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,4 +208,9 @@ result <- set_titles(result, tab_titles)
# Output listing
###############################################################################

tt_to_tlgrtf(head(result, 100), file = fileid, orientation = "landscape")
tt_to_tlgrtf(head(result, 100),
file = fileid, orientation = "landscape",
alignments = list(
list(row = 1:100, col = 1:8, value = "left")
)
)
Comment on lines +211 to +216

@shajoezhu shajoezhu Mar 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @munoztd0 , will this change be called a lot?

@munoztd0 munoztd0 Mar 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I don't understand, what do you mean by "called a lot" and which change ? @shajoezhu

@shajoezhu shajoezhu Mar 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my question was that will this kinda of function call appear in many places, for example, in your other test souce_code?

@munoztd0 munoztd0 Mar 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes these appears at in every test, again this is just a demonstration that you ask to see what would be the difference if we changed a column width..

No I the main PR #209 we pre compute the column width before so we hard coded the column widths so we will never have this change affect the scda tests.

@shajoezhu shajoezhu Mar 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. thanks man. so i guess, we can close this now?

4 changes: 3 additions & 1 deletion tests/testthat/source_code/tsfae09.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,4 +194,6 @@ result <- set_titles(result, tab_titles)
# Convert to tbl file and output table
################################################################################

tt_to_tlgrtf(result, file = fileid, orientation = "landscape")
tt_to_tlgrtf(head(result, 100), file = fileid, orientation = "landscape", alignments = list(
list(row = 1:10, col = 1:4, value = "left")
))
15 changes: 9 additions & 6 deletions tests/testthat/source_code/tsidem01.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,9 @@ lyt <- basic_table(
.stats = c("n", "mean_sd", "median", "range", "count_fraction"),
.labels = c("n" = "N", "range" = "Min, max"),
.formats = c(P1_precision,
n = jjcsformat_xx("xx"),
"count_fraction" = jjcsformat_count_fraction),
n = jjcsformat_xx("xx"),
"count_fraction" = jjcsformat_count_fraction
),
.indent_mods = c(
"n" = 0L,
"mean_sd" = 1L,
Expand Down Expand Up @@ -265,8 +266,9 @@ lyt <- basic_table(
.stats = c("n", "mean_sd", "median", "range", "count_fraction"),
.labels = c("n" = "N", "range" = "Min, max"),
.formats = c(P2a_precision,
n = jjcsformat_xx("xx"),
"count_fraction" = jjcsformat_count_fraction),
n = jjcsformat_xx("xx"),
"count_fraction" = jjcsformat_count_fraction
),
.indent_mods = c(
"n" = 0L,
"mean_sd" = 1L,
Expand All @@ -285,8 +287,9 @@ lyt <- basic_table(
.stats = c("n", "mean_sd", "median", "range", "count_fraction"),
.labels = c("n" = "N", "range" = "Min, max"),
.formats = c(P2b_precision,
n = jjcsformat_xx("xx"),
"count_fraction" = jjcsformat_count_fraction),
n = jjcsformat_xx("xx"),
"count_fraction" = jjcsformat_count_fraction
),
.indent_mods = c(
"n" = 0L,
"mean_sd" = 1L,
Expand Down
Loading