Skip to content

Fix the visible-keys plugin (keyup crash + missing stylesheet) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DmitrySharabin merged 2 commits into from
Jun 11, 2026
Merged

Fix the visible-keys plugin (keyup crash + missing stylesheet) #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1630bd
Fix the visible-keys keyup handler (undefined label and element ref)
DmitrySharabin Jun 10, 2026
019bb32
Load the visible-keys plugin's stylesheet (hasCSS was missing)
DmitrySharabin Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions visible-keys/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Display certain keys pressed
import Inspire from "@inspirejs/core";

export const hasCSS = true;

export const symbols = {
Tab: "⇥",
Enter: "⏎",
Expand Down Expand Up @@ -30,7 +32,7 @@ Inspire.hooks.add("slidechange", env => {
"keyup",
(listener = async evt => {
if (keys.has(evt.key) && evt.target.nodeName != "TEXTAREA") {
label = evt.key;
let label = evt.key;

for (let key in symbols) {
label = label.replace(key, symbols[key]);
Expand All @@ -47,9 +49,10 @@ Inspire.hooks.add("slidechange", env => {
"beforeend",
`<kbd class="visible-key">${label}</kbd>`,
);
let kbd = env.slide.lastElementChild;

await key.animate([{ opacity: 0 }], { duration: 400, delay }).finished;
key.remove();
await kbd.animate([{ opacity: 0 }], { duration: 400, delay }).finished;
kbd.remove();
}
}),
);
Expand Down