check functions for equality and clone props and content properties#44
Open
valoricDe wants to merge 1 commit intoinstructure-react:masterfrom
Open
check functions for equality and clone props and content properties#44valoricDe wants to merge 1 commit intoinstructure-react:masterfrom
valoricDe wants to merge 1 commit intoinstructure-react:masterfrom
Conversation
TuningGuide
reviewed
Oct 6, 2016
| if(typeof c1 === 'function' && typeof c2 === 'function') { | ||
| return c1.toString() === c2.toString(); | ||
| } | ||
| if(c1.hasOwnProperty('items') && c2.hasOwnProperty('items')) { |
There was a problem hiding this comment.
the check for items is possibly unnecessary as the config is cloned before given to tinymce so the items properties are not modified anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will result in much less rerendering and thus less or none cursor jumping