Skip to content

Fix temporary bubble for queued ChatGPT messages #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
int04 merged 1 commit into from
Sep 8, 2026
Merged

Fix temporary bubble for queued ChatGPT messages #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web/src/pages/TasksPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ function TasksWorkspace() {
return;
}
if (event.taskId === taskId && (event.type === 'approval.pending' || event.type === 'conversation.approval_pending' || event.type === 'conversation.title_updated')) { setDetailVersion((value) => value + 1); return; }
if (event.taskId === taskId && event.type.startsWith('chatgpt.queue.')) return;
if (event.taskId === taskId) {
const compactEvent = compactLiveToolEvent(event);
setLiveEvents((current) => mergeTimelineEvents(current, [compactEvent]));
Expand Down
9 changes: 8 additions & 1 deletion web/src/test/subagentUi.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ vi.mock('../chatgpt/compact/CompactHistoryCard', () => ({ CompactHistoryCard: ()
vi.mock('../chatgpt/ChatGptConversation', () => ({ ChatGptTaskCard: () => null, ChatGptTaskComposer: () => <textarea aria-label="Message" />, NewChatGptConversation: () => null }));
vi.mock('../tasks/TaskAccessCard', () => ({ TaskAccessCard: () => null }));
vi.mock('../tasks/TaskTerminalSection', () => ({ TaskTerminalSection: () => null }));
vi.mock('../tasks/TaskTurnBubble', () => ({ TaskTurnBubble: ({ subagents }: { subagents: SubagentRun[] }) => <div data-testid="turn-children">{subagents.map((v) => v.name).join(', ')}</div> }));
vi.mock('../tasks/TaskTurnBubble', () => ({ TaskTurnBubble: ({ turn, subagents }: { turn: { id: string }; subagents: SubagentRun[] }) => <div data-testid="turn-children" data-turn-id={turn.id}>{subagents.map((v) => v.name).join(', ')}</div> }));

function agent(id: string, parentTaskId: string, parentTurnId = 'root-turn'): SubagentRun {
return { id, name: id, taskId: `task-${id}`, parentTaskId, parentTurnId, rootTurnId: 'root-turn', request: '', status: 'running', attempt: 1, maxRuntimeMs: 1800000, createdAtUtc: '2026-09-06T00:00:00Z', updatedAtUtc: '2026-09-06T00:00:00Z' };
Expand Down Expand Up @@ -50,6 +50,13 @@ describe('subagent tree and chat layout', () => {
expect(container.querySelector('.task-detail-sidebar')).toBeNull();
expect(container.querySelector('.task-detail-shell')).toHaveClass('sidebar-collapsed');
});
it('does not create a temporary turn bubble for ChatGPT queue events', async () => {
chat();
expect(screen.getByTestId('turn-children')).toHaveAttribute('data-turn-id', 'root-turn');
act(() => scene.listener?.({ id: 'queue-created', type: 'chatgpt.queue.created', taskId: 'task-chat-root', occurredAt: '2026-09-06T00:00:01Z', payload: { messageId: 'queued-1' } }));
await waitFor(() => expect(screen.getByTestId('turn-children')).toHaveAttribute('data-turn-id', 'root-turn'));
expect(screen.getAllByTestId('turn-children')).toHaveLength(1);
});
it('refreshes the root when a grandchild status arrives on the immediate parent task', async () => {
chat();
act(() => scene.listener?.({ id: 'grandchild-update', type: 'subagent.status', taskId: 'task-child', occurredAt: '2026-09-06T00:00:00Z', payload: { childTaskId: 'task-grandchild', status: 'completed' } }));
Expand Down
Loading