Skip to content

Bump groovy-ssh, modernize Gradle, Groovy 3.#379

Merged
int128 merged 3 commits into
int128:masterfrom
elijahfhopp:master
Jan 15, 2023
Merged

Bump groovy-ssh, modernize Gradle, Groovy 3.#379
int128 merged 3 commits into
int128:masterfrom
elijahfhopp:master

Conversation

@elijahfhopp

Copy link
Copy Markdown
Contributor

This PR fixes (presumably) fixes #352 and is related to this groovy-ssh PR: int128/groovy-ssh#294 .

This would fix auth failures with modern SSH servers. See groovy-ssh PR.

It also includes Gradle build script modernization since it wouldn't even build with the latest Gradle version (7.6 as of writing).

Requirements for merge

  • groovy-ssh/Groovy SSH 2.8.0 #294 must be merged and published, then we can bump the version in the Gradle script.

Backward compatibility

  • Should be entirely compatible.

@elijahfhopp

Copy link
Copy Markdown
Contributor Author

I also have local changes to be able to publish the new version to Gradle Plugin Portal with their official plugin. I can open that as another PR if this one is merged.

@int128

int128 commented Jan 14, 2023

Copy link
Copy Markdown
Owner

I just published a new version to https://github.com/int128/groovy-ssh/packages/1771580. Could you check it?

@int128

int128 commented Jan 14, 2023

Copy link
Copy Markdown
Owner

I confirmed this works in #380. Thank you for your great work!

Comment thread gradle-ssh-plugin/core/build.gradle Outdated
Comment thread gradle-ssh-plugin/core/build.gradle

@int128 int128 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@int128 int128 merged commit a066794 into int128:master Jan 15, 2023
int128 pushed a commit that referenced this pull request May 25, 2025
#379)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting com.jcraft.jsch.JSchException: Auth fail

2 participants