Conversation
Contributor
Author
|
Ticket was created: Editor Roadmap (view) |
danim1130
approved these changes
Feb 13, 2025
| } | ||
|
|
||
| // When the active window is the editor itself, we don't want to send the active-info message to the editor | ||
| if (listenToSelf === false && title.includes("Editor")) { |
Collaborator
There was a problem hiding this comment.
This might filter out other applications, specify to "Grid Editor". Also, we might add "Electron" to the filter for when we run the Editor in dev mode
Contributor
Author
Yes, thanks for the update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue I.
Active window did not work on macOS, it only emitted the active window upon starting the package.
The issue was a missing initialization, with osx related init option.
From the node-active-window docs:
Issue II.
When clicking the Editor, then the active window info text gets overwritten with Editor itself. This is counterproductive when there is the Apply button.
Added the option to "Listen to Editor focus for Active window info", which is disabled (false) by default.
This does not disable the page change message activated when one of the page changes are Editor.
Test