Skip to content
This repository was archived by the owner on Aug 6, 2025. It is now read-only.

bug: fix review-dog github action#28

Merged
NeethuESim merged 1 commit intointel-retail:mainfrom
francis-tanyx:bug-26
Mar 25, 2025
Merged

bug: fix review-dog github action#28
NeethuESim merged 1 commit intointel-retail:mainfrom
francis-tanyx:bug-26

Conversation

@francis-tanyx
Copy link

@francis-tanyx francis-tanyx commented Mar 5, 2025

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/core-services/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

.github/.reviewdogConfig.yml was updated so that hadolint can find all Dockerfile within subfolder of root
upload-artifacte version has been bumped into v4 from v3 as v3 is depreciated

Issue this PR will close

close: #26

Anything the reviewer should know when reviewing this PR?

This pull request makes the change such that hadolint runs on all Dockerfile within this repository.
if we only want to to only look specific Dockerfile which is not specific from the source code I can fix it if instruction is given

Test Instructions if applicable

create pull request containing code change and let existing CI run

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/core-services )

bump upload-artifact from v3 to v4
fix .github/.reviewdogConfig.yml to provide proper Dockerfile file path to hadolint

Issue (intel-retail#26)[[https://github.com/intel-retail/core-services/issues/26]](https://github.com/intel-retail/core-services/issues/26] "intel-retail#26]")

Co-authored-by: Low Yu Zhe <yu.zhe.low@intel.com>
Signed-off-by: Tan Yan Xue <yan.xue.tan@intel.com>  
Signed-off-by: Ong Jing Hong <jing.hong.ong@intel.com>  
Signed-off-by: Marcus Khaw Chin Rui <marcus.chin.rui.khaw@intel.com>  
Signed-off-by: Voon Yong Shing <yong.shing.voon@intel.com>
@francis-tanyx
Copy link
Author

#Test Results:
image

Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeethuESim NeethuESim merged commit 3e87281 into intel-retail:main Mar 25, 2025
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: fix reviewdog github action

4 participants