This repository was archived by the owner on Aug 6, 2025. It is now read-only.
bug: fix review-dog github action#28
Merged
NeethuESim merged 1 commit intointel-retail:mainfrom Mar 25, 2025
Merged
Conversation
bump upload-artifact from v3 to v4 fix .github/.reviewdogConfig.yml to provide proper Dockerfile file path to hadolint Issue (intel-retail#26)[[https://github.com/intel-retail/core-services/issues/26]](https://github.com/intel-retail/core-services/issues/26] "intel-retail#26]") Co-authored-by: Low Yu Zhe <yu.zhe.low@intel.com> Signed-off-by: Tan Yan Xue <yan.xue.tan@intel.com> Signed-off-by: Ong Jing Hong <jing.hong.ong@intel.com> Signed-off-by: Marcus Khaw Chin Rui <marcus.chin.rui.khaw@intel.com> Signed-off-by: Voon Yong Shing <yong.shing.voon@intel.com>
Author
NeethuESim
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Checklist
What are you changing?
.github/.reviewdogConfig.yml was updated so that hadolint can find all Dockerfile within subfolder of root
upload-artifacte version has been bumped into v4 from v3 as v3 is depreciated
Issue this PR will close
close: #26
Anything the reviewer should know when reviewing this PR?
This pull request makes the change such that hadolint runs on all Dockerfile within this repository.
if we only want to to only look specific Dockerfile which is not specific from the source code I can fix it if instruction is given
Test Instructions if applicable
create pull request containing code change and let existing CI run
If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/core-services )