Skip to content

fix: add bounds checks for hard-coded slice index access #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harp-intel merged 1 commit into from
Feb 19, 2026
+108 −0
Merged

fix: add bounds checks for hard-coded slice index access #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions cmd/benchmark/benchmark_renderers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ import (
)

func renderFrequencyTable(tableValues table.TableValues) (out string) {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return
}
var rows [][]string
headers := []string{""}
valuesStyles := [][]string{}
Expand All @@ -30,6 +34,10 @@ func renderFrequencyTable(tableValues table.TableValues) (out string) {
}

func coreTurboFrequencyTableHTMLRenderer(tableValues table.TableValues) string {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]report.ScatterPoint{}
datasetNames := []string{}
for _, field := range tableValues.Fields[1:] {
Expand Down Expand Up @@ -79,8 +87,16 @@ func memoryBenchmarkTableMultiTargetHtmlRenderer(allTableValues []table.TableVal
data := [][]report.ScatterPoint{}
datasetNames := []string{}
for targetIdx, tableValues := range allTableValues {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
continue
}
points := []report.ScatterPoint{}
for valIdx := range tableValues.Fields[0].Values {
if valIdx >= len(tableValues.Fields[1].Values) {
slog.Error("field values length mismatch", slog.String("table", tableValues.Name), slog.Int("index", valIdx))
break
}
latency, err := strconv.ParseFloat(tableValues.Fields[0].Values[valIdx], 64)
if err != nil {
slog.Error("error parsing latency", slog.String("error", err.Error()))
Expand Down
4 changes: 4 additions & 0 deletions cmd/metrics/print.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,10 @@ func printMetricsTxt(metricFrames []MetricFrame, metricDefinitions []MetricDefin
name := nameFromMetricDefinition(metricDefinitions, metricFrames[0].Metrics[i].Name)
line = fmt.Sprintf("%-70s ", name)
for _, metricFrame := range metricFrames {
if i >= len(metricFrame.Metrics) {
slog.Error("metric frame has fewer metrics than expected", slog.Int("index", i), slog.Int("metrics", len(metricFrame.Metrics)))
break
}
line += fmt.Sprintf("%15s", strconv.FormatFloat(metricFrame.Metrics[i].Value, 'g', 4, 64))
}
outputLines = append(outputLines, line)
Expand Down
88 changes: 88 additions & 0 deletions cmd/telemetry/telemetry_renderers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ import (
)

func telemetryTableHTMLRenderer(tableValues table.TableValues, data [][]float64, datasetNames []string, chartConfig report.ChartTemplateStruct, datasetHiddenFlags []bool) string {
if len(tableValues.Fields) == 0 {
slog.Error("no fields in table", slog.String("table", tableValues.Name))
return ""
}
tsFieldIdx := 0
var timestamps []string
for i := range tableValues.Fields[0].Values {
Expand Down Expand Up @@ -53,6 +57,10 @@ func renderLineChart(xAxisLabels []string, data [][]float64, datasetNames []stri
}

func cpuUtilizationTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 3 {
slog.Error("insufficient fields in table, expected at least 3", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]float64{}
datasetNames := []string{}
// collect the busy (100 - idle) values for each CPU
Expand Down Expand Up @@ -102,6 +110,10 @@ func cpuUtilizationTelemetryTableHTMLRenderer(tableValues table.TableValues, tar
}

func utilizationCategoriesTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]float64{}
datasetNames := []string{}
for _, field := range tableValues.Fields[1:] {
Expand Down Expand Up @@ -137,6 +149,10 @@ func utilizationCategoriesTelemetryTableHTMLRenderer(tableValues table.TableValu
}

func irqRateTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 3 || len(tableValues.Fields[0].Values) == 0 {
slog.Error("insufficient fields or empty values in table, expected at least 3 fields with values", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]float64{}
datasetNames := []string{}
for _, field := range tableValues.Fields[2:] { // 1 data set per field, e.g., %usr, %nice, etc., skip Time and CPU fields
Expand All @@ -146,6 +162,10 @@ func irqRateTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName
points := []float64{}
total := 0.0
for i := range field.Values {
if i >= len(tableValues.Fields[0].Values) {
slog.Error("field values length mismatch", slog.String("table", tableValues.Name), slog.Int("index", i))
break
}
if tableValues.Fields[0].Values[i] != timeStamp { // new timestamp?
points = append(points, total)
total = 0.0
Expand Down Expand Up @@ -180,14 +200,26 @@ func irqRateTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName
// - one scatter chart per drive, showing the drive's utilization over time
// - each drive stat is a separate dataset within the chart
func driveTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 3 {
slog.Error("insufficient fields in table, expected at least 3", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
var out strings.Builder
driveStats := make(map[string][][]string)
for i := range tableValues.Fields[0].Values {
if i >= len(tableValues.Fields[1].Values) {
slog.Error("field values length mismatch", slog.String("table", tableValues.Name), slog.Int("index", i))
break
}
drive := tableValues.Fields[1].Values[i]
if _, ok := driveStats[drive]; !ok {
driveStats[drive] = make([][]string, len(tableValues.Fields)-2)
}
for j := range len(tableValues.Fields) - 2 {
if i >= len(tableValues.Fields[j+2].Values) {
slog.Error("field values length mismatch", slog.String("table", tableValues.Name), slog.Int("field", j+2), slog.Int("index", i))
continue
}
driveStats[drive][j] = append(driveStats[drive][j], tableValues.Fields[j+2].Values[i])
}
}
Expand Down Expand Up @@ -238,14 +270,26 @@ func driveTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName s
// - one scatter chart per network device, showing the device's utilization over time
// - each network stat is a separate dataset within the chart
func networkTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 3 {
slog.Error("insufficient fields in table, expected at least 3", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
var out strings.Builder
nicStats := make(map[string][][]string)
for i := range tableValues.Fields[0].Values {
if i >= len(tableValues.Fields[1].Values) {
slog.Error("field values length mismatch", slog.String("table", tableValues.Name), slog.Int("index", i))
break
}
drive := tableValues.Fields[1].Values[i]
if _, ok := nicStats[drive]; !ok {
nicStats[drive] = make([][]string, len(tableValues.Fields)-2)
}
for j := range len(tableValues.Fields) - 2 {
if i >= len(tableValues.Fields[j+2].Values) {
slog.Error("field values length mismatch", slog.String("table", tableValues.Name), slog.Int("field", j+2), slog.Int("index", i))
continue
}
nicStats[drive][j] = append(nicStats[drive][j], tableValues.Fields[j+2].Values[i])
}
}
Expand Down Expand Up @@ -293,6 +337,10 @@ func networkTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName
}

func memoryTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]float64{}
datasetNames := []string{}
for _, field := range tableValues.Fields[1:] {
Expand Down Expand Up @@ -328,6 +376,10 @@ func memoryTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName
}

func averageFrequencyTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]float64{}
datasetNames := []string{}
for _, field := range tableValues.Fields[1:] {
Expand Down Expand Up @@ -363,6 +415,10 @@ func averageFrequencyTelemetryTableHTMLRenderer(tableValues table.TableValues, t
}

func powerTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]float64{}
datasetNames := []string{}
for _, field := range tableValues.Fields[1:] {
Expand Down Expand Up @@ -398,6 +454,10 @@ func powerTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName s
}

func temperatureTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]float64{}
datasetNames := []string{}
for _, field := range tableValues.Fields[1:] {
Expand Down Expand Up @@ -433,6 +493,10 @@ func temperatureTelemetryTableHTMLRenderer(tableValues table.TableValues, target
}

func ipcTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]float64{}
datasetNames := []string{}
for _, field := range tableValues.Fields[1:] {
Expand Down Expand Up @@ -468,6 +532,10 @@ func ipcTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName str
}

func c6TelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]float64{}
datasetNames := []string{}
for _, field := range tableValues.Fields[1:] {
Expand Down Expand Up @@ -515,6 +583,10 @@ func instructionTelemetryTableHTMLRenderer(tableValues table.TableValues, target
sum float64
}
entries := []instrEntry{}
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
for _, field := range tableValues.Fields[1:] { // skip timestamp field
points := []float64{}
sum := 0.0
Expand Down Expand Up @@ -586,9 +658,17 @@ func renderGaudiStatsChart(tableValues table.TableValues, chartStatFieldName str
slog.Error("no gaudi chartStatFieldName field found")
return ""
}
if len(tableValues.Fields) == 0 {
slog.Error("no fields in table", slog.String("table", tableValues.Name))
return ""
}
// group the data points by module_id
moduleStat := make(map[string][]float64)
for i := range tableValues.Fields[0].Values {
if i >= len(tableValues.Fields[moduleIdFieldIdx].Values) || i >= len(tableValues.Fields[chartStatFieldIndex].Values) {
slog.Error("field values length mismatch", slog.String("table", tableValues.Name), slog.Int("index", i))
break
}
moduleId := tableValues.Fields[moduleIdFieldIdx].Values[i]
val, err := strconv.ParseFloat(tableValues.Fields[chartStatFieldIndex].Values[i], 64)
if err != nil {
Expand Down Expand Up @@ -638,6 +718,10 @@ func gaudiTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName s
}

func pduTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]float64{}
for _, field := range tableValues.Fields[1:] {
points := []float64{}
Expand Down Expand Up @@ -675,6 +759,10 @@ func pduTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName str
}

func kernelTelemetryTableHTMLRenderer(tableValues table.TableValues, targetName string) string {
if len(tableValues.Fields) < 2 {
slog.Error("insufficient fields in table, expected at least 2", slog.String("table", tableValues.Name), slog.Int("fields", len(tableValues.Fields)))
return ""
}
data := [][]float64{}
datasetNames := []string{}
for _, field := range tableValues.Fields[1:] {
Expand Down