Repository navigation
link-rot: open the issue when the check times out too - #71
Merged
xaleryb merged 1 commit intoOct 21, 2026
Merged
Conversation
`report` ran on failure() only, but a job that hits timeout-minutes ends cancelled, not failed, so a hung weekly run went red with nobody told. It now runs on a failed or cancelled `links` result. A skipped one, which is what the repository guard gives a fork, still opens nothing; that is why the condition names the two results rather than testing != 'success'.
xaleryb
added a commit
that referenced
this pull request
Oct 21, 2026
* ci: weekly link-rot check over skills and repo docs validate_skills.py --docs extends --check-links to markdown outside skills/ (README, CONTRIBUTING, MAINTAINERS, SECURITY, templates/, evaluation/). link-rot.yml runs it every Monday and opens or comments on one issue on failure. Also strip trailing emphasis markers from extracted URLs: **[x](url)** produced 'url)**' and a false 404 on README's catalog link. * validate_skills: move the --docs links out of main() (#70) The --docs branch added an if/elif and a loop to main(), and CodeFactor flags main() as a Complex Method on #67. doc_links() now owns the flag check and the collection, so main() gains one line and its complexity is back where it is on main. No change in behaviour: with no flags, with --docs alone and with --check-links --docs the output is byte-identical to 69836c7, and a dead link added to README.md fails the same way before and after. * link-rot: open the issue when the check times out too (#71) `report` ran on failure() only, but a job that hits timeout-minutes ends cancelled, not failed, so a hung weekly run went red with nobody told. It now runs on a failed or cancelled `links` result. A skipped one, which is what the repository guard gives a fork, still opens nothing; that is why the condition names the two results rather than testing != 'success'. --------- Co-authored-by: Alexander Rybkin <alexander.rybkin@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #67:
reportruns onfailure(), but alinksjob that hitstimeout-minutesends cancelled, not failed, so a hung weekly run goes red and opens no issue.The condition now names the two results that should open one:
Testing
!= 'success'instead, as I first suggested on #67, would be wrong: in a fork the repository guard skipslinks, andskippedwould then open an issue there.linksOnly scheduled runs report, as before.
actionlintis clean. The table follows GitHub's expression semantics; a scheduled run can't be triggered from a pull request.