fix: configure Kubernetes DNS search domains in mesh#539
Open
Sam6734 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Sam <55770131+Sam6734@users.noreply.github.com>
✅ Deploy Preview for interlink-dev canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Fixes DNS resolution for Dask workers in the mesh by ensuring Kubernetes CoreDNS is preferred over host/public resolvers and by removing an incorrect LOCALDOMAIN override that interfered with name resolution.
Changes:
- Reorders
/etc/resolv.confto place Kubernetes DNS ({{.DNSServiceIP}}) before the host DNS entry. - Removes the
LOCALDOMAINexport and the associated temporaryresolv.confgeneration that incorrectly set a filename as a search domain.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
90
to
95
| mkdir -p /tmp/etc-override | ||
| echo "search default.svc.cluster.local svc.cluster.local cluster.local" > /tmp/etc-override/resolv.conf | ||
| echo "nameserver $HOST_DNS" >> /tmp/etc-override/resolv.conf | ||
| echo "nameserver {{.DNSServiceIP}}" >> /tmp/etc-override/resolv.conf | ||
| echo "nameserver $HOST_DNS" >> /tmp/etc-override/resolv.conf | ||
| echo "nameserver 1.1.1.1" >> /tmp/etc-override/resolv.conf | ||
| echo "nameserver 8.8.8.8" >> /tmp/etc-override/resolv.conf |
Signed-off-by: Sam <55770131+Sam6734@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dask workers could start their WireGuard tunnels, but they could not resolve the Kubernetes name of the Dask scheduler. The mesh script treated a DNS configuration filename as a search domain. They eventually failed with:
OSError: Timed out trying to connect to tls://dask-daskclusterid.cmsaf-dev:8786 after 30 sThis change removes the LOCALDOMAIN override and places k8s CoreDNS before the host and public DNS servers in /etc/resolv.conf. Workers can now resolve and connect to the scheduler, while retaining their existing DNS servers as fallbacks.