Preserve show-all pagination when sorting the auction list. - #1625
Merged
Merged
Conversation
Sorting and the show-all toggle were overwriting each other's query params, so the list fell back to 15 rows after a sort. Co-authored-by: Cursor <cursoragent@cursor.com>
Ruby Array#sort and PostgreSQL collations disagree on names like extra-1 vs extra-10, which made CI fail while local tests passed. Co-authored-by: Cursor <cursoragent@cursor.com>
mmeest
requested review from
OlegPhenomenon and
maricavor
and removed request for
OlegPhenomenon and
maricavor
September 1, 2026 12:25
|
Contributor
🚀 Deploy Complete!
(Environment ready for testing) |
maricavor
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1623
Sorting and the show-all toggle were overwriting each other's query params, so the list fell back to 15 rows after a sort.
Now when auctions are sorted on list view(by domain name, auction type or bid) and after that list view changed from 15 -> all,
then sorted order remains as selected by user.
Same logic works both ways. If user selects previously 'list all auctions' and then uses sort, then list view still displays all auctions(in sorted order by selected value).