Skip to content

Feedback#37

Open
LaurieMV wants to merge 85 commits into
Feedbackfrom
main
Open

Feedback#37
LaurieMV wants to merge 85 commits into
Feedbackfrom
main

Conversation

@LaurieMV
Copy link
Copy Markdown

Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.

  1. Your teacher created this pull request as a place to leave feedback on your work. It will update automatically.
  2. In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
  3. Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.

Joshua Benavides and others added 30 commits June 3, 2025 13:07
Name, Description, Price, Category, Image
Express Route to GET all Items
Front-end View for all Items
Did some small changes to the visuals
added refresh to the back button
…nd-orders

creating Users and order files
mks257 and others added 29 commits June 6, 2025 14:23
Copy link
Copy Markdown
Author

@LaurieMV LaurieMV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, team! You completed all tiers plus lots of bonus. You did a nice job with your design and wireframe. The app has consistent styling. You provided sort, a shopping cart and orders. You wrote automatic tests for both the client and the server, with especially good coverage of the server. Your README is sufficient but slightly out of date.

<>
<h1>Inventory App</h1>
{/* Render the items */}
{/* 🧾 App Title */}
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot going on here. Consider refactoring into new components, e.g. for the Item List and the Cart.

Comment thread package.json
"version": "3.0.0",
"scripts": {
"test": "jest",
"test:server": "jest --config=jest.server.config.js --runInBand",
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see you were able to do testing! The server tests have almost complete coverage, way to go.

category: "",
})
} catch(err) {
throw new Error(err);
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what will the user see when this error occurs?

width="20%"
height="20%"
/>
<h3 className="price">Price: ${item.price}</h3>
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If price is 22.30, will this show 22.3?
Look into Intl.NumberFormat for displaying your price using best practices, here and in the forms

Comment thread server/models/index.js
@@ -1,5 +1,19 @@
const Item = require("./Item");
const User = require("./User");
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions to ordering functionality
Should a Cart create an Order?

Comment thread README.md

You are a team of developers for an e-commerce company. The Engineering team is rebuilding their inventory tracking app from the ground up. Your team has been tasked with creating a Full-Sack (front and back end) RESTful CRUD application to track the items.
# Description of the App
Our Inventory App provides users with comprehensive inventory management capabilities, including the ability to view, update, and delete specific items, as well as seamlessly add new inventory entries. The application also incorporates an advanced search feature, enabling efficient retrieval of items based on their names to streamline inventory operations.
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have shopping cart as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants