-
Notifications
You must be signed in to change notification settings - Fork 0
update-kotlin-2.3.0-and-agp-9.0.0 #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…0.0-rc.1 and baselineprofile to 1.5.0-alpha01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates Kotlin from version 2.2.21 to 2.3.0 and Android Gradle Plugin (AGP) from 8.13.2 to 9.0.0-rc03, along with Gradle from 8.14.3 to 9.2.1. The update includes adopting Kotlin 2.3.0's explicit backing fields feature, removing the deprecated iosX64 target, updating various dependencies, and making necessary API adjustments for AGP 9.0.
Changes:
- Upgraded Kotlin to 2.3.0 and AGP to 9.0.0-rc03, with Gradle updated to 9.2.1
- Adopted Kotlin 2.3.0's explicit backing fields syntax, replacing private backing fields with the new
field =syntax across ViewModels and state holders - Removed iosX64 target support and updated build configurations to use new AGP 9.0 APIs
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Updated Gradle distribution from 8.14.3 to 9.2.1 |
| gradle/shared.versions.toml | Updated Kotlin to 2.3.0 and several plugin versions |
| gradle/buildSrc.versions.toml | Updated AGP to 9.0.0-rc03, Kotlin to 2.3.0, added KSP plugin, removed kotlin-android plugin |
| gradlew / gradlew.bat | Updated Gradle wrapper scripts to use -jar execution method |
| gradle.properties | Changed android.nonFinalResIds from false to true |
| build.gradle.kts | Added KSP plugin to classpath, removed kotlin-android plugin |
| app/build.gradle.kts | Added new Kotlin compiler flags, removed kotlin-android plugin |
| app/proguard-rules.pro | Added ProGuard rule to remove Kotlin null check messages |
| baselineprofile/build.gradle.kts | Added new Kotlin compiler flags, removed kotlin-android plugin |
| buildSrc/.../SharedLibraryPlugin.kt | Updated to use new LibraryExtension API, added compiler flags, removed kotlin-android plugin |
| buildSrc/.../SharedKmmLibraryPlugin.kt | Updated to use KotlinMultiplatformAndroidLibraryTarget, removed iosX64 target, added compiler flags |
| shared/integration/databases/build.gradle.kts | Removed iosX64 KSP dependency |
| feature/expenses/.../ExpensesInteractor.kt | Migrated refreshExpenses to use explicit backing field syntax |
| feature/events/.../JoinEventViewModel.kt | Migrated state to use explicit backing field syntax |
| feature/events/.../AddPersonsViewModel.kt | Migrated state to use explicit backing field syntax |
| feature/events/.../EventsSyncStateHolder.kt | Migrated state to use explicit backing field syntax |
| feature/events/.../EventDeletionStateManagerImpl.kt | Migrated eventsDeletionState to use explicit backing field syntax, removed StateFlow import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ses/src/commonMain/kotlin/com/inwords/expenses/feature/expenses/domain/ExpensesInteractor.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a09dcea4b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...ts/src/commonMain/kotlin/com/inwords/expenses/feature/events/domain/EventsSyncStateHolder.kt
Show resolved
Hide resolved
...ses/src/commonMain/kotlin/com/inwords/expenses/feature/expenses/domain/ExpensesInteractor.kt
Show resolved
Hide resolved
080414b to
b7d3b9c
Compare
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 26 out of 27 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7d3b9cf47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
No description provided.