fix(image): cancel stale H.264 seek repairs - #34
Merged
Conversation
Co-authored-by: joaner <joaner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cancel obsolete H.264 seek-repair range queries before they can reset the worker or enqueue frames for an older seek target.
Motivation / related issue
Rapid consecutive rewinds can resolve out of order. An older range query could previously overwrite the decoder state established for the latest seek.
Type of change
Checklist
npm run lintpasses with no errorsnpm testpasses (648 tests)npm run buildandnpm run build:libsucceedAdditional verification:
npm run typecheckandnpx playwright test tests/image-h264.spec.ts.Re-submitted via fork workflow (replaces closed upstream PR #32).