Feature/v0.7.6.2 into main - #50
Merged
Merged
Conversation
…ally to ensure no tags are dropped, there are no unexpandable templates, and no phantoms. Pairs tested as of this commit: imports, relocations, tls, debug, exports, delay_imports
…it also includes additional tests that cover code paths the pair had not previously had tests for. Also removes unused tombstone code from validator as this was not used, and covered by SIGNATURE_INVALID_LENGTH
…ng entry_truncated and entry_read_failed from the validator priority list as these are already covered
… the current parser and validator. 1. Parser now does not consume errors as before during resource table walk, instead emitting a string_table_walk_failed tombstone, 2. This tombstone is now consumed in the validator and emitted as a dedicated reason code RESOURCE_STRING_TABLE_UNREADABLE
… to surface 3 new sub-reason codes.
…uct vars to localised_struct. Wrap pe.__data__ in getattr. Fix data directory offset bug that was treating PE32+ as PE32. Try/catch around rva_size unpacking
…tual_directories by 1
…oesn't care that their output lands in analysis or metadata rather than internal, only how tags flow.
…hings the pair confirms together: The filter drops by key name, not by position. Comments sits last in the .rc and is the only key missing at default — the other 8 pass through untouched. keys_filtered fires when and only when something is dropped. Present at default, absent under full. That's the flag doing real work rather than being decorative. The 64-cap stays out of the way. truncated is ['keys_filtered'] at default, not ['keys_filtered', 'strings'] — with 9 keys total, nothing approaches the limit. This is the property your padding fix guarantees. Everything outside strings is invariant. file_version, languages, translations, decoded, structural_error_count are identical across both. The tier touches exactly one field and nothing else leaks between modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.