Skip to content

chore: latest-7#66

Merged
andredestro merged 1 commit into7.xfrom
chore/latest-7
Nov 26, 2025
Merged

chore: latest-7#66
andredestro merged 1 commit into7.xfrom
chore/latest-7

Conversation

@andredestro
Copy link
Copy Markdown
Contributor

No description provided.

@andredestro andredestro self-assigned this Nov 25, 2025
Copy link
Copy Markdown
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the release.config.cjs file, but shouldn't that change be made on main branch instead of in 7.x?

And I think release_plugin.yml file should also be updated to allow 7.x branch, unless we don't want automatic releases, I see main was first added but then removed.

@OS-pedrogustavobilro
Copy link
Copy Markdown
Contributor

OS-pedrogustavobilro commented Nov 25, 2025

I'm not familiar with the release.config.cjs file, but shouldn't that change be made on main branch instead of in 7.x?

I am 80% sure this only needs to be on the branch from which the release will run.

So soon main will be for latest which will be Cap 8.

We won't be using next until Cap 9 (or ever again if we decide to drop it)

And 7.x will run for latest-7.

Then the GitHub action runs from the branch we select, so when running for 7.x it will clone the repo at that branch, and will run semantic-release with the config from that branch.

I say I'm 80% sure, because we properly haven't done this (releases with maintenance branches) for semantic-release yet, but I remember testing in the past with --dry-run locally and that's what happened. It's a matter of running the pipeline after the PR is merged and see what happens (it won't trigger a release, but it should not say that the branch is missing in the logs).

And I think release_plugin.yml file should also be updated to allow 7.x branch, unless we don't want automatic releases, I see main was first added but then removed.

This is a matter for debate I suppose, sometimes with PRs merged to main it would generate a release right away when in fact I wanted to bundle two PRs in same release. For maintenance branches, I guess it's not really a problem because I don't think we'll be bundling loads of patches.

That being said, in my opinion I'm fine as is, and would prefer removing the automatic triggers altogether, so that we're conscious on what we release - at least that's what we have for older capacitor repos.

@andredestro andredestro merged commit d61529a into 7.x Nov 26, 2025
8 checks passed
@andredestro andredestro deleted the chore/latest-7 branch November 26, 2025 14:06
OS-pedrogustavobilro pushed a commit that referenced this pull request Dec 16, 2025
capacitor-bot pushed a commit that referenced this pull request Dec 16, 2025
## [7.1.7](v7.1.6...v7.1.7) (2025-12-16)

### Bug Fixes

* Use latest-7 fox 7.x ([#66](#66)) ([356c9dc](356c9dc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants