Skip to content

feat: Allow reading part of a file - #10

Merged
OS-pedrogustavobilro merged 4 commits into
ionic-team:mainfrom
HarelM:main
Jan 21, 2026
Merged

feat: Allow reading part of a file#10
OS-pedrogustavobilro merged 4 commits into
ionic-team:mainfrom
HarelM:main

Conversation

@HarelM

@HarelM HarelM commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

PR Description

Original PR added a new readRange method.

Has since been refactored by @OS-pedrogustavobilro to Implement partial read of files by adding optional offset and length to readFile and readFileInChunks. The parameters were added to new overloaded methods instead of changing the existing ones. While breaking changes are acceptable in this library (known consumers are only our plugins), this one was avoidable.

Context

Allow reading only part of a file

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Tests

Refer to unit tests for validating changes.

For the team reviewing this PR, you can test using this OutSystems app -> Click "Files", write a file, then click it to open a new screen to read, there you'll be able to expand options for offset and length.

@HarelM HarelM changed the title feat: Add readRange method to library feat: Add readRange method Dec 31, 2025
@OS-pedrogustavobilro OS-pedrogustavobilro self-assigned this Jan 13, 2026
Drop new readRange method, since it's more useful to add this functionality to readFile and readFileInChunks.

References: https://outsystemsrd.atlassian.net/browse/RMET-4376
@OS-pedrogustavobilro OS-pedrogustavobilro changed the title feat: Add readRange method feat: Allow reading part of a file Jan 16, 2026
@OS-pedrogustavobilro
OS-pedrogustavobilro requested a review from a team January 16, 2026 11:52
@OS-pedrogustavobilro
OS-pedrogustavobilro merged commit 326b78e into ionic-team:main Jan 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants