fix: raw file paths without a scheme couldn't be accessed - #16
Merged
OS-pedrogustavobilro merged 5 commits intoSep 1, 2026
Merged
Conversation
OS-pedrogustavobilro
requested review from
a team,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
markemer and
theproducer
and removed request for
a team
August 17, 2026 16:47
markemer
reviewed
Aug 17, 2026
…ttps://github.com/ionic-team/OSFilesystemLib-iOS into fix/RMET-3892/contacts-photo-no-file-scheme
andredestro
approved these changes
Sep 1, 2026
OS-pedrogustavobilro
deleted the
fix/RMET-3892/contacts-photo-no-file-scheme
branch
September 1, 2026 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where passing raw file paths (not using a specific
Directorylike.library) without a scheme (e.g. nofile://) was causing them to be incorrectly interpreted as a scheme-less URI (which iOS's file APIs can't actually read from or write to), and fail to be accessed. The fix involves checking if the received input actually has a valid scheme, and if not interpret it as a plain file path and convert to a URI.Change Type
Rationale / Problems Fixed
Internal JIRA Ref: https://outsystemsrd.atlassian.net/browse/RMET-3892
Testing an app with Contacts and File Plugin. The contact's photo, when available, was coming without a
file://scheme, which was causing the File Plugin to not access it correctly.Tests or Reproductions
Refer to updated unit tests that pass after doing the fix (if you remove the fix they won't pass).
If you want to test on an actual mobile app -> You may use the current "Contacts Sample App" to reproduce the current issue.
To test the fix, you'll need to build this app from source, which hardcodes an xcframework with this fix (just unzip, open in Xcode and build and run):
Screenshots / Media
Before: Check video on RMET-3892
After: https://github.com/user-attachments/assets/184b793b-4923-4085-af5b-0e7e2c6f5c31