This repository was archived by the owner on May 1, 2020. It is now read-only.
locationStrategy: 'path' deeplinks#1545
Open
JoeMeeks wants to merge 1 commit intoionic-team:masterfrom
Open
Conversation
|
Hello @JoeMeeks I was also facing same problem and your solution is working , but when will it be available for us to use ? As I have added that line of code manually in node module |
Author
|
@Pyav123 I wish I knew. I submitted this PR for review 3 months ago. |
Contributor
|
Hey there! Most of the team's efforts are focused on supporting Ionic Framework v5. As a result, it is unlikely this PR will get reviewed/merged. You are more than welcome to fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
enable 404 redirects in http-server.ts to allow
locationStrategy: 'path'to work with deeplinks when runningionic:serveper ionic-team/ionic-framework#10565 (comment)Changes proposed in this pull request:
Fixes: #
"Cannot GET /[deeplink-path]" no longer occurs and redirects work not using hash navigation