Update regex for Webpack ContextReplacementPlugin to work w/latest Ionic / Angular#34
Merged
leifwells merged 1 commit intoionic-team:masterfrom May 13, 2017
johnstonbl01:master
Merged
Update regex for Webpack ContextReplacementPlugin to work w/latest Ionic / Angular#34leifwells merged 1 commit intoionic-team:masterfrom johnstonbl01:master
leifwells merged 1 commit intoionic-team:masterfrom
johnstonbl01:master
Conversation
|
@johnstonbl01 What version of Ionic has this fix? thanks in advance! |
|
@johnstonbl01 any help with this issue is really appreciated! 🙏 ionic-team/ionic-framework#11072 |
Contributor
Author
|
@jdnichollsc I honestly don't remember what version this was happening with. 😞 It was whatever the most recent version was back in April of this year -- 3ish, I think? I no longer have that code on this machine to confirm though -- sorry. |
|
Yeah, this keeps happening with the latest version :/ |
|
@johnstonbl01 but what do you think with the following PR? ionic-team/ionic-app-scripts#1360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the latest version of Ionic, I was seeing:
The updated regular expression should resolve both of these issues. See similar issue here: ionic-team/ionic-framework#11072