Add support for flags provided with equal signs#9
Open
jaredcwhite wants to merge 1 commit intoioquatix:mainfrom
Open
Add support for flags provided with equal signs#9jaredcwhite wants to merge 1 commit intoioquatix:mainfrom
jaredcwhite wants to merge 1 commit intoioquatix:mainfrom
Conversation
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a migration of the CLI in the Bridgetown web framework from Thor to Samovar. One of the blockers we identified is wanting to continue supporting flags written out in a key=value syntax. So for example:
should be handled identically, which is what this PR solves. Let me know what you think about this approach! (Also I just realized I should write tests, if you're interested in the future.) Thanks.