Conversation
- Added a high-level C++ wrapper for POSIX socket operations in `sockets.hpp` and `sockets.cpp`. - Introduced `ClientSocket`, `ServerSocket`, and `EndPointSocket` classes for client-side, server-side, and endpoint socket functionalities. - Implemented `SSL_Socket` class for secure socket operations using OpenSSL, including methods for initializing SSL contexts, connecting, and accepting secure connections. - Created unit tests for basic socket lifecycle, client and server socket creation, and socket info copying in `socket_test.cpp`. - Ensured thread safety and proper resource management using RAII principles.
… memory management; add integration tests for SST C++ API lifecycle and error handling
… build/test instructions and architecture overview
- Centralize OpenSSL initialization to address security issues. - Validate socket before closing to prevent errors. - Improve string handling in configuration parsing with snprintf. - Refactor socket lifecycle management in authentication handshake. - Implement bounds checking for received messages. - Ensure graceful SSL shutdown in SSL_Socket destructor. - Optimize thread-safe initialization of SSL contexts.
…estructor for proper resource management
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review my interpretation and implementation of the cpp api code.