Conversation
…s native drag and a custom title bar docs page
…d best-effort on macos and linux
… the page world on macos and linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR
Two features developed and tested on
alpha-5, landing toward the next release.Cross-platform frameless title bars (
9e8bdcb)src/main/platform/window-controls.ts) so it's injected identically on Windows, macOS, and Linux.--app-region: dragis mirrored to native-webkit-app-regionso macOS drags natively (WinCairo ignores-webkit-app-region, which is why the custom property exists).website/src/content/docs/concepts/frameless-windows.md.BrowserWindow.setPosition/setBounds/getPosition(107dc3e)SetWindowPos, verified by a real round-trip integration test (getBoundsreads the change back throughGetWindowRect).setFrameOrigin:(bottom-left origin; top-left mapping is a follow-up).Testing
validate:windows→ 185 pass, 0 fail (type-check + lint clean).tests/integration/windows/window-bounds.test.ts(engine-gatedSetWindowPos/GetWindowRectround-trip) and the frameless-window probe.Honest caveat
The macOS/Linux window-control handlers and Linux native drag are deferred — they need on-device verification that can't be done from a Windows machine, and a bug there could break window creation. The API surface and macOS native drag are in; the native handlers are the next, test-on-device step. The docs and parity table say exactly this.