provider: implement dht provide interface#969
Closed
guillaumemichel wants to merge 5 commits into
Closed
Conversation
Member
Author
|
@galargh do you know why CI refuses to run? |
Contributor
Yes, we need to update our billing information in the organisation settings. I've raised it in our shared Slack now. |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #969 +/- ##
==========================================
+ Coverage 61.55% 61.61% +0.06%
==========================================
Files 254 254
Lines 31420 31438 +18
==========================================
+ Hits 19340 19370 +30
+ Misses 10503 10497 -6
+ Partials 1577 1571 -6
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
Author
|
Moved Provide wrapper to kubo in ipfs/kubo#10834 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is used to test integration with ipfs/kubo#10834
Context
We initially want to make the DHT reprovide improvement opt-in. The new DHT
providerpackage (under development) comes as a replacement of the olderboxo/providerpackage. Since users will be able to choose whether to use the old or new system during the transition period, both systems need to share the same interface.As we want to eventually modernize the provide interfaces, it is sensible to use the new interface as a standard. The new provider interface is currently discussed in libp2p/go-libp2p-kad-dht#1093.
Changes
Since the boxo
reproviderdoesn't track which keys should be reprovided, most operations from the new interface simply correspond toProvide(). Both systems are eventually similar, because garbage collection of keys to be reprovided is done using the same mechanism (KeyChanFunc).One notable difference is that the new system doesn't have a manual
Reprovidecommand to force reprovide all keys instantly.