Skip to content

provider: implement dht provide interface#969

Closed
guillaumemichel wants to merge 5 commits into
mainfrom
dht-provider
Closed

provider: implement dht provide interface#969
guillaumemichel wants to merge 5 commits into
mainfrom
dht-provider

Conversation

@guillaumemichel

Copy link
Copy Markdown
Member

This PR is used to test integration with ipfs/kubo#10834


Context

We initially want to make the DHT reprovide improvement opt-in. The new DHT provider package (under development) comes as a replacement of the older boxo/provider package. Since users will be able to choose whether to use the old or new system during the transition period, both systems need to share the same interface.

As we want to eventually modernize the provide interfaces, it is sensible to use the new interface as a standard. The new provider interface is currently discussed in libp2p/go-libp2p-kad-dht#1093.

Changes

Since the boxo reprovider doesn't track which keys should be reprovided, most operations from the new interface simply correspond to Provide(). Both systems are eventually similar, because garbage collection of keys to be reprovided is done using the same mechanism (KeyChanFunc).

One notable difference is that the new system doesn't have a manual Reprovide command to force reprovide all keys instantly.

@guillaumemichel

Copy link
Copy Markdown
Member Author

@galargh do you know why CI refuses to run?

The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings

@galargh

galargh commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

@galargh do you know why CI refuses to run?

The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings

Yes, we need to update our billing information in the organisation settings. I've raised it in our shared Slack now.

@codecov

codecov Bot commented Jul 8, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 61.61%. Comparing base (b524969) to head (50b64b4).

Files with missing lines Patch % Lines
provider/reprovider.go 10.00% 18 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
+ Coverage   61.55%   61.61%   +0.06%     
==========================================
  Files         254      254              
  Lines       31420    31438      +18     
==========================================
+ Hits        19340    19370      +30     
+ Misses      10503    10497       -6     
+ Partials     1577     1571       -6     
Files with missing lines Coverage Δ
provider/reprovider.go 56.67% <10.00%> (-3.20%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guillaumemichel

Copy link
Copy Markdown
Member Author

Moved Provide wrapper to kubo in ipfs/kubo#10834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants