fix: remove bare CID etag test for dir listings#281
Merged
Conversation
Contributor
|
Results against Kubo master: Summary
|
Contributor
|
Results against Kubo latest: Summary
|
Remove If-None-Match test that sent W/"<CID>" for a directory listing and expected 304. The gateway ETag for directory listings is "DirIndex-<hash>_CID-<CID>", which never matches a bare CID. Matching a bare CID is an optimization specific to boxo/gateway (which checks If-None-Match against both the CID ETag and the DirIndex ETag before doing any I/O). This is not a spec requirement for all gateway implementations. Test moved to ipfs/boxo: ipfs/boxo#1129 Fixes #261
lidel
force-pushed
the
fix/dir-listing-etag-test
branch
from
March 31, 2026 22:44
a72aa9e to
7417a04
Compare
lidel
marked this pull request as ready for review
March 31, 2026 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes If-None-Match test that sent
W/"<CID>"for a directory listing and expected 304. The gateway ETag for directory listings is"DirIndex-<hash>_CID-<CID>", which never matches a bare CID.This test was copied from old go-ipfs, and does not belong here.
Matching a bare CID is an optimization specific to
boxo/gateway(which checks If-None-Match against both the CID ETag and the DirIndex ETag before doing any I/O). This is not a spec requirement for all gateway implementations.