fix: distinguish suite results from test results#287
Merged
Conversation
Contributor
|
Results against Kubo master: Summary
|
Contributor
|
Results against Kubo latest: Summary
|
lidel
marked this pull request as ready for review
April 1, 2026 00:58
Parse test2json NDJSON with encoding/json to reliably detect package-level events and rename their pass/fail actions to suite_pass/suite_fail. - transformSuiteEvents uses json.Unmarshal to check for "Test" key - bytes.SplitSeq/bytes.Replace avoid string conversions - add TestTransformSuiteEvents
lidel
force-pushed
the
fix/250-suite-action
branch
from
April 1, 2026 01:11
58ad5d8 to
449b384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON report now uses
suite_pass/suite_failactions for package-level events, so consumers no longer need to infer suite vs test by checking for the absence of a "Test" key.