propagate error when "request is not valid"#163
Open
Conversation
Member
|
This LGTM but the error may have been hidden for security reasons (e.g., the error may be sent over the network?). CC @hannahhoward for context and merge/close. |
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
…sfer (#163) * add ChannelStage to keep track of lifecycle of DataTransfer * better errors * fix tests * backward compat in case Stages is nil * remove logger as we dont use it * add godocs to stages objects. * make linter happy * remove `queued data` log Co-authored-by: raulk <raul@protocol.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It'd be nice for this to hit
go-graphsync, because this error is quite useful - we noted that we have client/miner out of sync and trying to create deals with the same internal identifiers were causing problems.