Open
Conversation
gammazero
approved these changes
May 12, 2023
Contributor
gammazero
left a comment
gammazero
left a comment
There was a problem hiding this comment.
Do you also want to ser defaultMaxInProgressRequests to something other than its current value?
rvagg
approved these changes
May 15, 2023
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
Not a bad point about defaultMaxInProgressRequests, 200 is a long way from the default 6, it seems like this is an acknowledgement that 6 is very low.
Changing it in this PR would make this a breaking change though, existing deployments may get bumped way beyond what they expect/want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
This came about cause we found some high volume clients were using the default config and having poor results because of it.
Felt like we should document this issue and provide some sensible defaults.
Implementation